In the jsconsole, the error "dispatch is not a function" is thrown in message.js:116:13.

Comment on attachment 8799362 [details] Bug 1308840 - Fixes expanding/collapsing stacktraces. ; https://reviewboard.mozilla.org/r/84556/#review83128 Awesome, thanks for the catch and the fix! LGTM. Just one minor question, but this can be landed without changing anything. ::: devtools/client/webconsole/new-console-output/components/message.js (Diff revision 1) > onViewSourceInDebugger: serviceContainer.onViewSourceInDebugger > }) : null; > attachment = dom.div({ className: "stacktrace devtools-monospace" }, child); > } > > - // If there is an expandable part, make it collapsible. Quick question, why remove this comment?

Comment on attachment 8799362 [details] Bug 1308840 - Fixes expanding/collapsing stacktraces. ; https://reviewboard.mozilla.org/r/84556/#review83128 > Quick question, why remove this comment? Because it is no longer relevant. We make the message collapsible if the `collapsible` prop is truthy, and I find the code self-explanatory here : ` if (collapsible) { // Create the collapse button ` I have no string opinion for this, I just thought the comment could be a little misleading, but I'll happilly put it back if you think the code is better with it.

Ok, if you don't have a strong opinion, let's add it back in. I like having a comment at the head of each larger block of code in that file so that someone who is unfamiliar with the code can scan it more easily. Feel free to reword it if you think it could be clearer.

I put the comment back and pushed to TRY https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a847b598894 . Everything seems fine, so I'm gonna push it.

Pushed by chevobbe.nicolas@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7078e9bd3895 Fixes expanding/collapsing stacktraces. r=linclark;