Closed Bug 1308946 Opened 8 years ago Closed 8 years ago

Message from History Panel is displayed in Synced devices folder

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

Product:
Firefox for Android Graveyard
Component:
Awesomescreen
Version:
52 Branch
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox51 unaffected, firefox52 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 52
Tracking Flags:
Tracking Status
firefox51 --- unaffected
firefox52 --- verified

People

(Reporter: sflorean, Assigned: JanH)

References

Details

(Keywords: regression)

Attachments

(3 files)

Screenshot_20161010-165742.png
(deleted), image/png
Details
Bug 1308946 - Part 0 - Import PanelLevel enum.
(deleted), text/x-review-board-request
liuche
: review+
Details
Bug 1308946 - Part 1 - Ensure that empty views not matching the current panel level are hidden.
(deleted), text/x-review-board-request
liuche
: review+
Details
Attached image Screenshot_20161010-165742.png (deleted) —
Environment: Device: Motorola Razr (Android 4.4.2); Build: Nightly 52.0a1 (2016-10-10); Steps to reproduce: 1. Open Fennec with a clean profile; 2. Go to History Panel -> Synced devices; Expected result: The following message is displayed: 'Welcome to Sync': 'Sign in to sync your tabs, bookmarks, logins & more. get started" Actual result: 1.Message from History Panel is displayed "Websites you visited most recently show up here" 2.The following message is displayed: 'Welcome to Sync': 'Sign in to sync your tabs, bookmarks, logins & more. get started" Notes: Please see the attached screenshot.
Assignee: nobody → jh+bugzilla
Blocks: 1270162
status-firefox51: --- → unaffected
Hardware: ARM → All
Regression window: Last good build: 28-09 First bad build: 29-09 Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=66a77b9bfe5dcacd50eccf85de7c0e7e15ce0ffd&tochange=f7d5008ee2ab9200052e45ad6ecc3f3a348f7f86 After further investigation, when returning to full history from sync devices the message "Welcome to Sync': 'Sign in to sync your tabs, bookmarks, logins & more. get started" is displayed in History panel. Please check the video: https://youtu.be/wIUTus9IoLQ Should I file a new bug or that will be fixed with patches from this bug?
Keywords: regression
It's the same thing.
Comment on attachment 8799927 [details] Bug 1308946 - Part 0 - Import PanelLevel enum. https://reviewboard.mozilla.org/r/84986/#review83914
Attachment #8799927 - Flags: review?(liuche) → review+
Comment on attachment 8799928 [details] Bug 1308946 - Part 1 - Ensure that empty views not matching the current panel level are hidden. https://reviewboard.mozilla.org/r/84988/#review83916 Thanks JanH, this looks reasonable to me, thanks for the fix.
Attachment #8799928 - Flags: review?(liuche) → review+
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2d8487048444 Part 0 - Import PanelLevel enum. r=liuche https://hg.mozilla.org/integration/autoland/rev/f7a6d2efbf88 Part 1 - Ensure that empty views not matching the current panel level are hidden. r=liuche
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2d8487048444 https://hg.mozilla.org/mozilla-central/rev/f7a6d2efbf88
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Verified as fixed in build 52.0a1 (2016-10-16); Device: Nexus 9 (Android 6.0.1) and LG G4 (Android 5.1).
Status: RESOLVED → VERIFIED
status-firefox52: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: