Open
Bug 1310011
Opened 8 years ago
Updated 2 years ago
Allow thread hang annotations to be set for in-progress hang
Categories
(Toolkit :: Telemetry, defect, P3)
Tracking
()
NEW
People
(Reporter: mconley, Assigned: mconley)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
I landed the ability for us to annotate hangs that occur during an e10s tab switch in bug 1303077. Unfortunately, this will only allow us to capture stacks if the hang occurs _after_ the force paint is requested and before the paint completes.
I suspect that the tab switch spinner occurs most often when the main thread in the content process is _already in the midst of a hang_, and the user switches tab.
Unfortunately, our annotation system for hangs only gathers annotations at the start of the hang.
I want to change this so that the hang monitor thread polls for annotations, and accumulates them during a hang.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mconley
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8800882 [details]
Bug 1310011 - Allow annotations on a hang to accumulate.
The HangAnnotations stuff is written using a more modern (and probably better) style than I'm used to. In particular, it's using things like UniquePtr and Move semantics.
What this patch is attempting to do is take some annotations, and add them to a possibly pre-existing set of annotations. I'm not handling nullptr cases very well just yet.
But this won't even compile, and I guess I have some studying to do with ::Move and stuff.
aklotz - the urgency of this is high enough that I think waiting for me to learn how to write modern C++ is likely too long a wait. Do you have any recommendations on how I can accomplish the accumulating behaviour correctly?
Attachment #8800882 -
Flags: feedback?(aklotz)
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8800882 [details]
Bug 1310011 - Allow annotations on a hang to accumulate.
I've had a night to sleep on this, and I think I see what I'm doing wrong. I'll hopefully have a working patch up today.
Attachment #8800882 -
Flags: feedback?(aklotz)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8800882 -
Flags: review?(aklotz)
Assignee | ||
Updated•8 years ago
|
Attachment #8800882 -
Flags: review?(aklotz)
Assignee | ||
Updated•8 years ago
|
Attachment #8800881 -
Flags: review?(aklotz)
Assignee | ||
Comment 7•8 years ago
|
||
The patch that switches HangAnnotations to use a std::map has moved to bug 1310809 instead.
Updated•8 years ago
|
Priority: -- → P3
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•