Tim Nguyen :ntim Reporter
	Description • 8 years ago

Old console:
>> var p = new Promise((resolve) => resolve(true))
<- Promise { <state>: "fulfilled", <value>: true }

New console:
>> var p = new Promise((resolve) => resolve(true))
<- Promise { }

The new console should support the old rep of Promises.

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 2 • 8 years ago
mozreview-review

Comment on attachment 8803967 [details]
Bug 1310608 - Add a Rep for Promises. ;

https://reviewboard.mozilla.org/r/88150/#review88432

Nice!

R+

Just one question inline.

Honza

::: devtools/client/shared/components/reps/promise.js:47
(Diff revision 1)
> +        keys.push("value");
> +      }
> +
> +      return keys.map((key, i) => {
> +        return PropRep(Object.assign({}, this.props, {
> +          mode: "tiny",

If the promise-resoloved-value is an object we don't have it's 'grip-preview' and so, we can't display its properties, right?

(that's why 'tiny' mode is used)

Honza

	Nicolas Chevobbe [:nchevobbe] Assignee
	Comment 3 • 8 years ago
mozreview-review-reply

Comment on attachment 8803967 [details]
Bug 1310608 - Add a Rep for Promises. ;

https://reviewboard.mozilla.org/r/88150/#review88432

> If the promise-resoloved-value is an object we don't have it's 'grip-preview' and so, we can't display its properties, right?
> 
> (that's why 'tiny' mode is used)
> 
> Honza

Yes, that's true.

FYI, this is how Promise are displayed in the old console : 
`Promise.resolve({a:"b"})` is logged as "Promise { <state>: "fulfilled", <value>: Object }"

	Nicolas Chevobbe [:nchevobbe] Assignee
	Comment 4 • 8 years ago

TRY looks good https://treeherder.mozilla.org/#/jobs?repo=try&revision=ced12925f233ea870e9419e7b7664dc8f4256ea5

	Pulsebot
	Comment 5 • 8 years ago

Pushed by chevobbe.nicolas@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b7e94b82004e
Add a Rep for Promises. r=Honza;

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/b7e94b82004e