Closed
Bug 1310804
Opened 8 years ago
Closed 8 years ago
Limit Mac remote printing to Nightly
Categories
(Core :: Security: Process Sandboxing, defect)
Tracking
()
RESOLVED
FIXED
mozilla52
People
(Reporter: haik, Assigned: haik)
References
Details
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
bobowen
:
review+
gchang
:
approval-mozilla-aurora+
|
Details |
Until bug 1310165 is fixed (which is a problem with Mac remote printing), Mac remote printing should be prevented from riding the trains. This bug fix is to limit Mac remote printing to Nightly. Mac remote printing is enabled in 51 now.
And, since the Mac level 1 content sandbox depends on remote printing, it should also be limited to Nightly. At present, it is only enabled on Nightly, but set to become enabled in 52.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → haftandilian
Assignee | ||
Comment 1•8 years ago
|
||
We don't need code changes to limit sandbox level=1 to Nightly because MOZ_CONTENT_SANDOX is already limited to Nightly for Mac builds.
Summary: Limit Mac remote printing and content sandbox level 1 to Nightly → Limit Mac remote printing to Nightly
Comment hidden (mozreview-request) |
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8801887 [details]
Bug 1310804 - Limit Mac remote printing to Nightly;
https://reviewboard.mozilla.org/r/86484/#review85454
r+ with the check fixed.
::: modules/libpref/init/all.js:1123
(Diff revision 1)
>
> // Print via the parent process. This is only used when e10s is enabled.
> -#if defined(XP_WIN) || defined(XP_MACOSX)
> +// For Mac, limit to Nightly.
> +#if defined(XP_WIN)
> +pref("print.print_via_parent", true);
> +#elif defined(XP_MACOSX) && defined(NIGHTLY)
This should be NIGHTLY_BUILD.
Attachment #8801887 -
Flags: review?(bobowencode) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 5•8 years ago
|
||
Please mark the pending issues in MozReview as resolved so that autoland can push it.
Keywords: checkin-needed
Assignee | ||
Comment 6•8 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)
> Please mark the pending issues in MozReview as resolved so that autoland can
> push it.
Done.
Flags: needinfo?(ryanvm)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/738663e0c33d
Limit Mac remote printing to Nightly; r=bobowen
Comment 9•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Assignee | ||
Comment 10•8 years ago
|
||
[Tracking Requested - why for this release]:
This is a workaround for a printing-to-PDF and PDF.js rendering issue in build 51--bug 1310165.
status-firefox51:
--- → affected
tracking-firefox51:
--- → ?
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 11•8 years ago
|
||
Comment on attachment 8801887 [details]
Bug 1310804 - Limit Mac remote printing to Nightly;
Approval Request Comment
[Feature/regressing bug #]:
Exposed by fix for 1228022.
[User impact if declined]:
On Mac, some PDF text will continue to be rasterized when it shouldn't be.
[Describe test coverage new/current, TreeHerder]:
Manually tested on Aurora build. No treeherder test coverage.
[Risks and why]:
Mac remote printing is not ready to ride the trains. We need this fix to disable it for all but Nightly builds.
[String/UUID change made/needed]:
None
Attachment #8801887 -
Flags: approval-mozilla-aurora?
Comment 12•8 years ago
|
||
Comment on attachment 8801887 [details]
Bug 1310804 - Limit Mac remote printing to Nightly;
Disable mac remote printing in aurora. Take it in 51 aurora.
Attachment #8801887 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•8 years ago
|
Comment 13•8 years ago
|
||
bugherder uplift |
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•