Closed Bug 1311194 Opened 8 years ago Closed 1 year ago

Avoid duplicating update binary on OSX

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
Unspecified
macOS
Type:
defect

Tracking

(firefox52 wontfix)

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
firefox52 --- wontfix

People

(Reporter: catlee, Unassigned)

References

Details

11:57:02 INFO - Duplicates 392392 bytes: 11:57:02 INFO - Nightly.app/Contents/Library/LaunchServices/org.mozilla.updater 11:57:02 INFO - Nightly.app/Contents/MacOS/updater.app/Contents/MacOS/org.mozilla.updater
Mass wontfix for bugs affecting firefox 52.
status-firefox52: affected → wontfix
Product: Core → Firefox Build System
Severity: normal → S3

These update binaries are used for different purposes and have different entry points. We could potentially split this functionality out into separate binaries (rather than duplicate binaries), but the counter-argument is that we keep update-related functionality in the same place in our code base and binaries, which can help prevent accidentally breaking our updates in the future. Personally, I would vote to close this bug as wontfix.

Flags: needinfo?(ahochheiden)

(In reply to Stephen A Pohl [:spohl] from comment #2)

Personally, I would vote to close this bug as wontfix.

Agreed.

Status: NEW → RESOLVED
Closed: 1 year ago
Flags: needinfo?(ahochheiden)
Resolution: --- → WONTFIX

(In reply to Alex Hochheiden [:ahochheiden] from comment #3)

(In reply to Stephen A Pohl [:spohl] from comment #2)

Personally, I would vote to close this bug as wontfix.

Agreed.

For posterity I wanted to add: today I realized that a symlink could possibly be used instead of duplicating the entire binary. However, I believe that this currently runs into limitations with our build system.

You need to log in before you can comment on or make changes to this bug.