Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Description • 8 years ago

https://dxr.mozilla.org/mozilla-central/rev/01ab78dd98805e150b0311cce2351d5b408f3001/xpcom/base/ErrorList.h#608-611,613
> #define MODULE NS_ERROR_MODULE_EDITOR
>   ERROR(NS_ERROR_EDITOR_NO_SELECTION,  FAILURE(1)),
>   ERROR(NS_ERROR_EDITOR_NO_TEXTNODE,   FAILURE(2)),
>   ERROR(NS_FOUND_TARGET,               FAILURE(3)),
> 
>   ERROR(NS_EDITOR_ELEMENT_NOT_FOUND,   SUCCESS(1)),
> #undef MODULE

Currently, NS_ERROR_EDITOR_NO_SELECTION and NS_ERROR_EDITOR_NO_TEXTNODE are not used.

NS_FOUND_TARGET is used but the name is odd.  It's an error code but doesn't start with NS_ERROR_.

NS_EDITOR_ELEMENT_NOT_FOUND is still used. Let's keep this.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 1 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd2eaad5d414

	(no longer active)
	Comment 5 • 8 years ago
mozreview-review

Comment on attachment 8802433 [details]
Bug 1311235 part.1 Remove NS_ERROR_EDITOR_NO_SELECTION and NS_ERROR_EDITOR_NO_TEXTNODE since nobody uses them

https://reviewboard.mozilla.org/r/86828/#review86266

	(no longer active)
	Comment 6 • 8 years ago
mozreview-review

Comment on attachment 8802434 [details]
Bug 1311235 part.2 Rename NS_FOUND_TARGET to NS_EDITOR_FOUND_TARGET and make it a success code

https://reviewboard.mozilla.org/r/86830/#review86268

	(no longer active)
	Comment 7 • 8 years ago
mozreview-review

Comment on attachment 8802435 [details]
Bug 1311235 part.3 Rename NS_EDITOR_ELEMENT_NOT_FOUND to NS_SUCCESS_EDITOR_ELEMENT_NOT_FOUND

https://reviewboard.mozilla.org/r/86832/#review86270

	Pulsebot
	Comment 8 • 8 years ago

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/9d74c8cfdec3
part.1 Remove NS_ERROR_EDITOR_NO_SELECTION and NS_ERROR_EDITOR_NO_TEXTNODE since nobody uses them r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/ce5ec4fc9f70
part.2 Rename NS_FOUND_TARGET to NS_EDITOR_FOUND_TARGET and make it a success code r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/4cf392058707
part.3 Rename NS_EDITOR_ELEMENT_NOT_FOUND to NS_SUCCESS_EDITOR_ELEMENT_NOT_FOUND r=Ehsan

	Guilherme Lima
	Comment 9 • 8 years ago

Landed 22 hours ago
https://hg.mozilla.org/mozilla-central/rev/9d74c8cfdec3
https://hg.mozilla.org/mozilla-central/rev/ce5ec4fc9f70
https://hg.mozilla.org/mozilla-central/rev/4cf392058707