Closed Bug 1311238 Opened 8 years ago Closed 4 years ago

Replace NS_ENSURE_* with |if (NS_WARN_IF(...|

Categories

(Core :: DOM: Editor, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox52 --- wontfix

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

editor still uses NS_ENSURE_* in a lot of places. Let's replace them with modern style. NS_ENSURE_SUCCESS(rv, *) -> if (NS_WARN_IF(NS_FAILED(rv))) { return *; } NS_ENSURE_TRUE(*1, *2) -> if (NS_WARN_IF(!*1)) { return *2; } NS_ENSURE_SUCCESS_VOID(rv) -> if (NS_WARN_IF(NS_FAILED(rv))) { return; } NS_ENSURE_TRUE_VOID(*) -> if (NS_WARN_IF(!*)) { return; }
Priority: -- → P3
Mass wontfix for bugs affecting firefox 52.

Already done under libeditor, but not so in spellchecker etc. I recommend you to file new bug for them when you work on this.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.