Closed
Bug 1311521
Opened 8 years ago
Closed 8 years ago
Use LoginFormFactory instead of FormLikeFactory. Port Bug 1302474 and Bug 1310049 to SeaMonkey.
Categories
(SeaMonkey :: Autocomplete, defect)
Tracking
(seamonkey2.48 unaffected, seamonkey2.49esr fixed)
RESOLVED
FIXED
seamonkey2.49
| Tracking | Status | |
|---|---|---|
| seamonkey2.48 | --- | unaffected |
| seamonkey2.49esr | --- | fixed |
People
(Reporter: frg, Assigned: frg)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
philip.chee
:
review+
|
Details | Diff | Splinter Review |
In Bug 1310049 FormLikeFactory was refactored into its own module. We need to replace it with LoginFormfactory which wraps it for use in login specific contexts.
|
Assignee | |
Comment 1•8 years ago
|
||
Error is gone and likely all which is needed but something broke the actual suggestions popup again. I need to fix Bug 1300547 first.
|
|
Assignee | |
Updated•8 years ago
|
Blocks: 2.49BulkMalfunctions
|
|
Assignee | |
Comment 2•8 years ago
|
||
Bug 1302474 changed a method name so took care of this here too. Uncoupling from bug 1300547 before the breaks pile up.
Attachment #8802688 -
Attachment is obsolete: true
Attachment #8805775 -
Flags: review?(iann_bugzilla)
|
|
Assignee | |
Updated•8 years ago
|
Summary: Use LoginFormFactory instead of FormLikeFactory. Port Bug 1310049 to SeaMonkey. → Use LoginFormFactory instead of FormLikeFactory. Port Bug 1302474 and Bug 1310049 to SeaMonkey.
|
|
||
Updated•8 years ago
|
Attachment #8805775 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•8 years ago
|
Target Milestone: --- → seamonkey2.49
You need to log in
before you can comment on or make changes to this bug.
Description
•