Closed Bug 1311557 Opened 8 years ago Closed 8 years ago

Sync ping will report errors for custom sync engines.

Categories

(Firefox :: Sync, defect, P1)

Product:
Firefox
Component:
Sync
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 52
Tracking Flags:
Tracking Status
firefox49 --- unaffected
firefox50 --- fixed
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: tcsc, Assigned: tcsc)

Details

Attachments

(1 file)

Bug 1311557 - Ensure custom sync engines aren't reported in sync ping.
(deleted), text/x-review-board-request
markh
: review+
ritu
: approval-mozilla-aurora+
ritu
: approval-mozilla-beta+
Details
The logic in `onEngineStop` (https://dxr.mozilla.org/mozilla-central/source/services/sync/modules/telemetry.js#329-341) is faulty and will cause us to add an engine record even if we should ignore the engine.
Assignee: nobody → tchiovoloni
Status: NEW → ASSIGNED
Priority: -- → P1
Comment on attachment 8803190 [details] Bug 1311557 - Ensure custom sync engines aren't reported in sync ping. https://reviewboard.mozilla.org/r/87436/#review86442
Attachment #8803190 - Flags: review?(markh) → review+
Pushed by tchiovoloni@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d4c055d13bc8 Ensure custom sync engines aren't reported in sync ping. r=markh
https://hg.mozilla.org/mozilla-central/rev/d4c055d13bc8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52: affected → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Thom, can you please request uplift to Aurora and Beta?
Flags: needinfo?(tchiovoloni)
Comment on attachment 8803190 [details] Bug 1311557 - Ensure custom sync engines aren't reported in sync ping. Approval Request Comment [Feature/regressing bug #]: bug 1267919 [User impact if declined]: Some PII in sync ping possible. See bug 1267919 comment 5. [Describe test coverage new/current, TreeHerder]: Includes tests which pass. [Risks and why]: Low risk, limited to sync. [String/UUID change made/needed]: None
Flags: needinfo?(tchiovoloni)
Attachment #8803190 - Flags: approval-mozilla-beta?
Attachment #8803190 - Flags: approval-mozilla-aurora?
Comment on attachment 8803190 [details] Bug 1311557 - Ensure custom sync engines aren't reported in sync ping. Taking this only due to the PII risk stated in the uplift otherwise it is too late to uplift such fixes in 50, Aurora51+, Beta50+
Attachment #8803190 - Flags: approval-mozilla-beta?
Attachment #8803190 - Flags: approval-mozilla-beta+
Attachment #8803190 - Flags: approval-mozilla-aurora?
Attachment #8803190 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: