Open
Bug 1311691
Opened 8 years ago
Updated 4 years ago
Clean up uses of |_selectionDetails/telemetrySearchDetails | in autocomplete
Categories
(Firefox :: Search, task, P3)
Firefox
Search
Tracking
()
NEW
People
(Reporter: Dexter, Unassigned)
References
Details
(Whiteboard: [fxsearch][search-telemetry-backlog])
From bug 1303333 comment 16:
> The entire _selectionDetails/telemetrySearchDetails stuff in autocomplete looks hackish to me, I'm not sure why search needs autocomplete to save this info, rather than overriding "handleEnter" and storing this info locally. The original changesets introducing this doesn't make sense to me.
> I also don't know why part of the telemetry collection is in handleSearchCommandWhere and part is in doSearch, rather than being well collected together in a method.
We should investigate why we're using _selectionDetails/telemetrySearchDetails this way instead of overriding handleEnter and eventually clean up the code, if needed.
Updated•8 years ago
|
Priority: -- → P3
Whiteboard: [fxsearch]
Comment 1•8 years ago
|
||
Mass wontfix for bugs affecting firefox 52.
Updated•4 years ago
|
Whiteboard: [fxsearch] → [fxsearch][search-telemetry-backlog]
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•