David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Description • 8 years ago

BasicCompositor uses gfxPlatform to create a temporary surface when handling 3D transforms [1]. The GPU process doesn't have gfxPlatform, so this doesn't work.

It's weird that we're using the basic compositor at all on treeherder here [2], which exposed this bug... that'll have to be investigated as well.

[1] http://searchfox.org/mozilla-central/source/gfx/layers/basic/BasicCompositor.cpp#574
[2] https://treeherder.mozilla.org/logviewer.html#?job_id=29210880&repo=try#L3057

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 1 • 8 years ago

I think this should be functionally equivalent since skia is now the default content backend everywhere.

Even when the content backend is Cairo, this should be the same except on Windows, where it looks like we'd have created a DIB-backed surface. But I don't think that matters.

	Pulsebot
	Comment 2 • 8 years ago

Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d23e41c16872
Don't use gfxPlatform for creating temporary surfaces in the BasicCompositor. (bug 1311770, r=mattwoodrow)

	Carsten Book [:Tomcat]
	Comment 3 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/d23e41c16872