Thomas Wisniewski Assignee
	Description • 8 years ago

The web platform tests for XMLHttpRequest abort() are presently being updated to better-match the spec text [1, 2]. This patch updates Firefox accordingly so that the revised tests will pass. Try seems fine with it [3].

Note that I'm not 100% sure if it would be better to make both aOptionalException and aRv pointers or Optionals<> in the new RequestErrorSteps method, rather than using NS_OK as a sentinel value for "do not throw an exception". Thoughts?

Also note that the same changes to the web platform tests in this patch are already being merged remotely [4], so there is no need to review them here. Once we're ready to land this patch, I will revise it appropriately to avoid any merge conflicts on our end.

[1] https://github.com/whatwg/xhr/issues/88
[2] https://xhr.spec.whatwg.org/#the-abort()-method
[3] https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1183408163bc88f1b172f7cc7e502fca8800490
[4] https://github.com/w3c/web-platform-tests/pull/4033