Closed Bug 1312218 Opened 8 years ago Closed 8 years ago

args is not defined at test-folder-display-helpers.js:328

Categories

(Thunderbird :: Testing Infrastructure, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 52.0

People

(Reporter: aceman, Assigned: aceman)

Details

Attachments

(1 file)

Found by https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=86ef5370c332227d87e95470ac305304b9588c5b 10:36:39 INFO - SUMMARY-UNEXPECTED-FAIL | test-session-store.js | test-session-store.js::teardownModule 10:36:39 INFO - EXCEPTION: args is not defined 10:36:39 INFO - at: test-folder-display-helpers.js line 328 10:36:39 INFO - teardownModule test-folder-display-helpers.js:328 1 10:36:39 INFO - Runner.prototype.wrapper frame.js:580 7 10:36:39 INFO - Runner.prototype._runTestModule frame.js:677 5 10:36:39 INFO - Runner.prototype.runTestModule frame.js:701 3 10:36:39 INFO - Runner.prototype.runTestDirectory frame.js:525 7 10:36:39 INFO - runTestDirectory frame.js:707 3 10:36:39 INFO - Bridge.prototype._execFunction server.js:179 10 10:36:39 INFO - Bridge.prototype.execFunction server.js:183 16 10:36:39 INFO - Session.prototype.receive server.js:283 3 10:36:39 INFO - AsyncRead.prototype.onDataAvailable server.js:88 3
Attached patch patch (deleted) — Splinter Review
Attachment #8803649 - Flags: review?(jorgk)
Comment on attachment 8803649 [details] [diff] [review] patch Review of attachment 8803649 [details] [diff] [review]: ----------------------------------------------------------------- Well, this should be an r- because I don't think it's right. Anyway, you can make it right by just passing null instead of args, see for example here: https://dxr.mozilla.org/comm-central/rev/7744a4fe857d4e5297a3a9312b1c6370ef294eac/mail/base/content/sanitize.js#250 https://dxr.mozilla.org/comm-central/rev/7744a4fe857d4e5297a3a9312b1c6370ef294eac/mail/test/mozmill/session-store/test-session-store.js#66 Or am I missing something? (If you intend to land this, be nice and land bug 1310440, too.)
Attachment #8803649 - Flags: review?(jorgk) → review+
Yes that is a possibility too.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: