Closed
Bug 1312412
Opened 8 years ago
Closed 8 years ago
WebSocket should reuse XHR's 'store large blobs in temp files' -setup
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: smaug, Assigned: baku)
References
Details
Attachments
(1 file)
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
See bug 1202006
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → amarchesini
Assignee | ||
Comment 1•8 years ago
|
||
For how WebSocket works, we don't append any data in order to create a blob but, what we receive, is the blob content.
That content is a nsCString. Instead doing what you are proposing, I want to implement a BlobImplString so that we don't duplicate the string when the Blob is created.
Reporter | ||
Comment 2•8 years ago
|
||
But could we store huge data still in temp files to reduce memory usage?
Assignee | ||
Comment 3•8 years ago
|
||
I would like to mark bug 704447 as duplicate of this.
Attachment #8803904 -
Flags: review?(bugs)
Reporter | ||
Comment 4•8 years ago
|
||
Isn't bug 704447 about sending. This is about receiving messages.
Assignee | ||
Comment 5•8 years ago
|
||
> But could we store huge data still in temp files to reduce memory usage?
Right. So, with this patch, we still have less duplicate memory because we reuse the string logic.
About bug 704447, we should implement a similar MutableBlobStorage class in necko.
Just because we have bug 704447, are you OK with me implementing this in that bug instead here?
Reporter | ||
Comment 6•8 years ago
|
||
Not sure I understand how bug 704447 and this one are connected.
Or would you do all file-backed blob handling in Necko or something?
(I don't care too much which bug is used, but as of now bug 704447 is about sending and this one is about receiving message and I was imaging they to be distinct enough things that they should be handled separately).
Reporter | ||
Comment 7•8 years ago
|
||
I guess we could take this string sharing patch anyhow. That should help with smaller blobs, those which won't be using temporary files.
Reporter | ||
Updated•8 years ago
|
Attachment #8803904 -
Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1239d6e55498
Introducing BlobImplString, r=smaug
Comment 9•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•