Closed
Bug 1312420
Opened 8 years ago
Closed 8 years ago
Default weekly report in update orphaning dashboard is broken
Categories
(Toolkit :: Application Update, defect, P4)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
People
(Reporter: spohl, Assigned: mhowell)
References
Details
Noticed this morning that the default selection in the update orphaning dashboard fails to fetch the right .json file. Somehow, [1] is now performing a mathematical addition of year, month and day before being treated as a string, resulting in a string of "2038.json" for the date of 2016-10-12. Previously, year, month and day were treated as strings and resulted in a string of "20161012.json". It might be as simple as changing this line to:
> var lastWedDataFile = "" + year + month + date + ".json";
or
> var lastWedDataFile = year + "" + month + "" + date + ".json";
but I haven't tested it.
[1] https://github.com/mozilla/telemetry-dashboard/blob/221d4b42f6e79dac7cc134e0011a15d6fbaa239d/update-orphaning/index.html#L135
Reporter | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
Assignee: nobody → mhowell
Assignee | ||
Comment 2•8 years ago
|
||
Above PR has been merged.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•