Closed
Bug 1312483
Opened 8 years ago
Closed 8 years ago
Baldr: don't partially import functions
Categories
(Core :: JavaScript Engine: JIT, defect, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: bbouvier, Assigned: bbouvier)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
The spec test suite unveiled an issue in our implementation: we can have situations where we import a table, partially assign elements to it, then abort, leaving the table partially initialized.
Attachment #8803955 -
Flags: review?(luke)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8803955 [details] [diff] [review]
partial.patch
Review of attachment 8803955 [details] [diff] [review]:
-----------------------------------------------------------------
Oh hah, this is another case where I filed the PR (https://github.com/WebAssembly/design/pull/780), got distracted while waiting for lgtm, and then forgot to write the patch. Thanks!
Attachment #8803955 -
Flags: review?(luke) → review+
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc5faef03008
Check that functions assigned to tables are wasm functions earlier before assigning them; r=luke
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•