Closed
Bug 1312574
Opened 8 years ago
Closed 8 years ago
Use cPickle instead of json to serialize the tests database
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox52 fixed)
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: chmanchester, Assigned: chmanchester)
References
Details
Attachments
(1 file)
This is faster, particularly on Windows. I have a patch for this, but it depends on details of bug 1312520 that haven't seen review yet.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8804432 [details]
Bug 1312574 - Use cPickle instead of json to serialize the build system's tests database.
https://reviewboard.mozilla.org/r/88400/#review88106
Looks good.
Next time, please write a descriptive commit message describing the improved performance. As a reviewer, it helps me weigh things like "is this change worth it."
Attachment #8804432 -
Flags: review?(gps) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12987daa4d68
Use cPickle instead of json to serialize the build system's tests database. r=gps
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•