Closed
Bug 1312936
Opened 8 years ago
Closed 8 years ago
Use ACString for nsITranserable.getAnyTransferData
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files)
To reduce small allocation and clean up editor code...
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8804537 [details]
Bug 1312936 - Part 1. Use ACString for nsITranserable.getAnyTransferData.
https://reviewboard.mozilla.org/r/88472/#review87548
::: widget/nsITransferable.idl:145
(Diff revision 1)
> *
> * @param aFlavor (out parameter) the flavor of data that was retrieved
> * @param aData the data. Some variant of class in nsISupportsPrimitives.idl
> * @param aDataLen the length of the data
> */
> - void getAnyTransferData ( out string aFlavor, out nsISupports aData, out unsigned long aDataLen ) ;
> + void getAnyTransferData ( out ACString aFlavor, out nsISupports aData,
I assume that only ASCII characters are available for Content-Type value. If no, we need to use AUTF8String.
Attachment #8804537 -
Flags: review?(masayuki) → review+
|
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8804538 [details]
Bug 1312936 - Part 2. Use nsAutoCString for nsITranserable.getAnyTransferData into editor.
https://reviewboard.mozilla.org/r/88474/#review87550
Excellent!
Attachment #8804538 -
Flags: review?(masayuki) → review+
|
|
||
Comment 5•8 years ago
|
||
FYI: there are similar issues in other IDLs, sigh.
https://dxr.mozilla.org/mozilla-central/search?q=flavor+path%3Aidl&redirect=false
Blocks: 1311232
|
Assignee | |
Comment 6•8 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8804537 [details]
Bug 1312936 - Part 1. Use ACString for nsITranserable.getAnyTransferData.
https://reviewboard.mozilla.org/r/88472/#review87548
> I assume that only ASCII characters are available for Content-Type value. If no, we need to use AUTF8String.
This is ASCII only
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80687b4d7461
Part 1. Use ACString for nsITranserable.getAnyTransferData. r=masayuki
https://hg.mozilla.org/integration/mozilla-inbound/rev/357f4f16be12
Part 2. Use nsAutoCString for nsITranserable.getAnyTransferData into editor. r=masayuki
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/80687b4d7461
https://hg.mozilla.org/mozilla-central/rev/357f4f16be12
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
|
|
||
Updated•5 years ago
|
Blocks: redesign-editor-scriptable-API
You need to log in
before you can comment on or make changes to this bug.
Description
•