Comment on attachment 8808546 [details] Bug 1313556 - Implement Crypto() for mp4 rust parser. https://reviewboard.mozilla.org/r/91362/#review91450 ::: media/libstagefright/binding/MP4Metadata.cpp:348 (Diff revision 1) > + if (mRustTestMode) { > + MOZ_DIAGNOSTIC_ASSERT(rustCrypto.pssh == crypto.pssh); > + } > +#endif > + > + if (mPreferRust && rustCrypto.pssh == crypto.pssh) { The Rust bits need to be protected by the MOZ_RUST_MP4PARSE define. I wonder if we should always use rustCrypto if mPreferRust; i.e. remove the equality test here? We'll catch mismatches via the assert above. ::: media/libstagefright/binding/MP4Metadata.cpp:679 (Diff revision 1) > + return; > + } > + > + nsTArray<uint8_t> pssh; > + pssh.AppendElements(info.data.data, info.data.length, fallible); > + mCrypto.Update(pssh.Elements(), pssh.Length()); Can't we pass info.data.data and info.data.length into mCrypto.Update directly, avoiding the copy into the local pssh array? ::: media/libstagefright/binding/include/mp4_demuxer/DecoderData.h:46 (Diff revision 1) > + > + bool operator==(const PsshInfo& aOther) const { > + if (uuid != aOther.uuid || data != aOther.data) { > + return false; > + } > + return true; This could just be return uuid == aOther.uuid && data == aOther.data;

Comment on attachment 8808546 [details] Bug 1313556 - Implement Crypto() for mp4 rust parser. https://reviewboard.mozilla.org/r/91362/#review91450 r+ with a few minor changes required

(In reply to Matthew Gregan [:kinetik] from comment #4) > Comment on attachment 8808546 [details] > Bug 1313556 - Implement Crypto() for mp4 rust parser. > > https://reviewboard.mozilla.org/r/91362/#review91450 > > r+ with a few minor changes required Thanks for review!

Comment on attachment 8809286 [details] Bug 1313556 - update rust parser for pssh parsing. https://reviewboard.mozilla.org/r/91868/#review92252

Pushed by ayang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3ee624382460 Implement Crypto() for mp4 rust parser. r=kinetik https://hg.mozilla.org/integration/autoland/rev/88e9a1a777f4 update rust parser for pssh parsing. r=rillian

We also need video extra_data and codec_specific_config to play video. I'll fix it in another bug.

https://hg.mozilla.org/mozilla-central/rev/3ee624382460 https://hg.mozilla.org/mozilla-central/rev/88e9a1a777f4