Closed
Bug 1313565
Opened 8 years ago
Closed 8 years ago
Convert NS_STYLE_USER_MODIFY, NS_STYLE_WINDOW_DRAGGING and NS_STYLE_ORIENT to enum classes
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: adamtomasv, Assigned: adamtomasv, Mentored)
References
Details
Attachments
(3 files)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161024172922
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Updated•8 years ago
|
Assignee: nobody → adamtomasv
|
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8805433 [details]
Bug 1313565 - Convert NS_STYLE_USER_MODIFY_* to enum class ;
https://reviewboard.mozilla.org/r/89168/#review88590
Attachment #8805433 -
Flags: review?(manishearth) → review+
|
|
||
Updated•8 years ago
|
Attachment #8805433 -
Flags: review?(xidorn+moz)
Attachment #8805434 -
Flags: review?(xidorn+moz)
Attachment #8805435 -
Flags: review?(xidorn+moz)
|
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8805434 [details]
Bug 1313565 - Convert NS_STYLE_WINDOW_DRAGGING_* to enum class ;
https://reviewboard.mozilla.org/r/89170/#review88594
::: layout/style/nsStyleStruct.h:3316
(Diff revision 1)
> nsChangeHint_ReflowChangesSizeOrPosition |
> nsChangeHint_ClearAncestorIntrinsics;
> }
>
> - mozilla::StyleUserSelect mUserSelect; // [reset] (selection-style)
> - uint8_t mForceBrokenImageIcon; // [reset] (0 if not forcing, otherwise forcing)
> + mozilla::StyleUserSelect mUserSelect; // [reset](selection-style)
> + uint8_t mForceBrokenImageIcon; // [reset]
Since the comment for `mForceBrokenImageIcon` isn't aligned anyway, we can just keep `mForceBrokenImageIcon` unaligned (one space after the `uint8_t`).
|
|
||
Comment 6•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8805434 [details]
Bug 1313565 - Convert NS_STYLE_WINDOW_DRAGGING_* to enum class ;
https://reviewboard.mozilla.org/r/89170/#review88596
Attachment #8805434 -
Flags: review?(manishearth) → review+
|
|
||
Comment 7•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8805435 [details]
Bug 1313565 - Convert NS_STYLE_ORIENT_* to enum class ;
https://reviewboard.mozilla.org/r/89172/#review88598
Attachment #8805435 -
Flags: review?(manishearth) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Updated•8 years ago
|
Attachment #8805434 -
Flags: review?(xidorn+moz)
Attachment #8805435 -
Flags: review?(xidorn+moz)
|
|
||
Comment 10•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8805433 [details]
Bug 1313565 - Convert NS_STYLE_USER_MODIFY_* to enum class ;
https://reviewboard.mozilla.org/r/89168/#review88680
Attachment #8805433 -
Flags: review?(xidorn+moz) → review+
|
|
||
Comment 11•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8805434 [details]
Bug 1313565 - Convert NS_STYLE_WINDOW_DRAGGING_* to enum class ;
https://reviewboard.mozilla.org/r/89170/#review88682
Attachment #8805434 -
Flags: review?(xidorn+moz) → review+
|
|
||
Comment 12•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8805435 [details]
Bug 1313565 - Convert NS_STYLE_ORIENT_* to enum class ;
https://reviewboard.mozilla.org/r/89172/#review88684
Attachment #8805435 -
Flags: review?(xidorn+moz) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 16•8 years ago
|
||
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6b80fdaeadfc
Convert NS_STYLE_USER_MODIFY_* to enum class ; r=manishearth,xidorn
https://hg.mozilla.org/integration/autoland/rev/cb8c35d77841
Convert NS_STYLE_WINDOW_DRAGGING_* to enum class ; r=manishearth,xidorn
https://hg.mozilla.org/integration/autoland/rev/050803173323
Convert NS_STYLE_ORIENT_* to enum class ; r=manishearth,xidorn
|
||
Comment 17•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6b80fdaeadfc
https://hg.mozilla.org/mozilla-central/rev/cb8c35d77841
https://hg.mozilla.org/mozilla-central/rev/050803173323
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•