Closed Bug 1313632 Opened 8 years ago Closed 8 years ago

Remove legacy OggReader

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: kaku, Assigned: jya)

References

Details

Attachments

(2 files)

Once we remove this from the code base, we can then remove MediaDecoder::DispatchSetStartTime().
Depends on: 1309516
Blocks: 1313635
Assignee: nobody → kaku
Assignee: kaku → jyavenard
Blocks: 1316211
Attachment #8808864 - Flags: review?(kaku) → review+
Comment on attachment 8808865 [details] Bug 1313632: P2. Cleaner Ogg related headers. https://reviewboard.mozilla.org/r/91598/#review91522 ::: dom/media/flac/FlacFrameParser.cpp:47 (Diff revision 1) > +FlacFrameParser::~FlacFrameParser() > +{ > +} Why do we add a destructor but doing nothing?
Attachment #8808865 - Flags: review?(kaku) → review+
Comment on attachment 8808865 [details] Bug 1313632: P2. Cleaner Ogg related headers. https://reviewboard.mozilla.org/r/91598/#review91522 > Why do we add a destructor but doing nothing? This is so I can use a forward declaration for some class types. Otherwise the default destructor wouldnt know how to deal with the nsAutoPtr and would cause a compilation warning about undefined behaviour. That way the destructor is defined and called where it has the full type definition
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: