At least for the robocop tests I was trying to run locally, mach always says tests not found. I think this is a regression from bug 1312520, more specifically inside `manifestparser.combine_fields`. For robocop tests for example, `global_vars` has {'subsuite': 'robocop'}, and `local_vars` has {'subsuite': ''}. When we combine the fields, the empty subsuite field in `local_vars` ends up replacing the subsuite field in `global_vars`, and the test ends up with an empty subsuite field. Subsequently, we filter out the test because the empty subsuite does not match the expected subsuite 'robocop'.

I see the issue. I have a provisional fix, although Andrew may have a better idea here.

Comment on attachment 8805620 [details] Bug 1313716 - Don't provide a blank subsuite as a default in the manifestparser. https://reviewboard.mozilla.org/r/89366/#review88580 Lgtm. I feel like there's some place this might come back to bite us, but doing this makes sense so I guess we can deal with that if it arises.

Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/425c0602ccb4 Don't provide a blank subsuite as a default in the manifestparser. r=ahal

This patch breaks `./mach mochitest js/xpconnect/tests/chrome/test_xrayToJS.xul` when run locally.

Yeah, after landing this, we can't specify any targets for mochitest.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ccdaf2b0cc9e69dd847551750acf5fb0e8e99f26 Backed out changeset 425c0602ccb4 (bug 1313716) for breaking mach mochitest. r=backout

Backed out for breaking mach mochitest

Andrew, are you ok with this as a fixup? Sorry to just paste it here, mozreview isn't letting me push to this bug again. diff --git a/testing/mozbase/manifestparser/manifestparser/filters.py b/testing/mozbase/m --- a/testing/mozbase/manifestparser/manifestparser/filters.py +++ b/testing/mozbase/manifestparser/manifestparser/filters.py @@ -138,17 +138,17 @@ class subsuite(InstanceFilter): else: test['subsuite'] = '' # Filter on current subsuite if self.name is None: if not test.get('subsuite'): yield test else: - if test.get('subsuite') == self.name: + if test.get('subsuite', '') == self.name: yield test class chunk_by_slice(InstanceFilter): """ Basic chunking algorithm that splits tests evenly across total chunks. :param this_chunk: the current chunk, 1 <= this_chunk <= total_chunks

Yep looks good assuming it's tested. Fwiw, you can go to the parent review request and click re-open there (not from the child view), then it should let you re-push. I think there's already work underway to improve that UX.

(In reply to Andrew Halberstadt [:ahal] from comment #14) > Yep looks good assuming it's tested. Fwiw, you can go to the parent review > request and click re-open there (not from the child view), then it should > let you re-push. I think there's already work underway to improve that UX. Aha, thanks!

Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fa43713a681d Don't provide a blank subsuite as a default in the manifestparser. r=ahal