Closed
Bug 1313741
Opened 8 years ago
Closed 5 years ago
Convert the DOM test release channel checks to AppConstants
Categories
(Core :: DOM: Core & HTML, defect, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla68
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: RyanVM, Assigned: RyanVM)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Right now, test_interfaces.html and some other DOM tests have their own logic for detecting a nightly or release build using a pattern along the lines of SpecialPowers.Cc['@mozilla.org/xre/app-info;1'].getService(SpecialPowers.Ci.nsIXULAppInfo).version followed by some parsing of the returned result.
This release channel functionality is now included in AppConstants.jsm and would be one less reinventing of the wheel in the tree if we converted the tests to use that instead.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ryanvm
Comment 1•8 years ago
|
||
Also happens in js/xpconnect/tests/chrome/test_xrayToJS.xul fwiw.
Comment 2•7 years ago
|
||
I'm assuming P3 here due to the lack of recent activity but feel free to correct me :)
Priority: -- → P3
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
Assignee | ||
Comment 3•6 years ago
|
||
I'm not going to get to this any time soon. Could be a good second bug perhaps?
Assignee: ryanvm → nobody
Summary: Convert the DOM test release channel checks to AppConstants.jsm → Convert the DOM test release channel checks to AppConstants
Assignee | ||
Comment 4•5 years ago
|
||
Turns out I need to fix this to avoid test failures once bug 1548655 lands on mozilla-beta.
Assignee | ||
Comment 5•5 years ago
|
||
Assignee | ||
Comment 6•5 years ago
|
||
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51b73cca09ea
Use AppConstants in DOM and XPConnect tests instead of manual detection. r=bzbarsky
Comment 8•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•