Closed
Bug 1313770
Opened 8 years ago
Closed 8 years ago
Fix missing checks for IPDL failures in layer transactions
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: dvander, Assigned: dvander)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
Ryan had an idea to put a self-destruct timer in the GPU process for testing, and this exposed a lot of latent bugs in layers. There are a bunch of places where IPDL can return false and these checks aren't handled properly.
Assignee | ||
Comment 1•8 years ago
|
||
Closes a can of worms. AddMutant was asserting that the transaction wasn't open.
Attachment #8805682 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8805686 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 3•8 years ago
|
||
This one is a little subtle: IPDL doesn't know about refcounts (yet), and a failed constructor always registers the actor. The addref has to move up before the Send+error check to make sure the refcount is balanced.
(This pattern is error-prone, but not worth fixing in IPDL just yet...)
Attachment #8805688 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8805689 -
Flags: review?(matt.woodrow)
Updated•8 years ago
|
Attachment #8805682 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #8805690 -
Flags: review?(matt.woodrow)
Updated•8 years ago
|
Attachment #8805686 -
Flags: review?(matt.woodrow) → review+
Updated•8 years ago
|
Attachment #8805688 -
Flags: review?(matt.woodrow) → review+
Updated•8 years ago
|
Attachment #8805689 -
Flags: review?(matt.woodrow) → review+
Updated•8 years ago
|
Attachment #8805690 -
Flags: review?(matt.woodrow) → review+
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9a887ab3ba6
Do not paint if a BeginTransaction fails. (bug 1313770 part 1, r=mattwoodrow)
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c31adc3869b
Make CreateImageClient fallible. (bug 1313770 part 2, r=mattwoodrow)
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8e078e03894
Handle failed SendPImageContainerConstructor. (bug 1313770 part 3, r=mattwoodrow)
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2f30ab32ece
Handle failed SendPCompositable. (bug 1313770 part 4, r=mattwoodrow)
https://hg.mozilla.org/integration/mozilla-inbound/rev/b555a8f33edb
Handle failed SendPTexture. (bug 1313770 part 5, r=mattwoodrow)
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c9a887ab3ba6
https://hg.mozilla.org/mozilla-central/rev/8c31adc3869b
https://hg.mozilla.org/mozilla-central/rev/a8e078e03894
https://hg.mozilla.org/mozilla-central/rev/d2f30ab32ece
https://hg.mozilla.org/mozilla-central/rev/b555a8f33edb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•