Closed
Bug 1314425
Opened 8 years ago
Closed 8 years ago
Assertion in TextureChild::~TextureChild when the GPU process aborts
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: dvander, Assigned: dvander)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
Sample job: https://treeherder.mozilla.org/#/jobs?repo=try&author=danderson@mozilla.com&selectedJob=30215401 Assertion: http://searchfox.org/mozilla-central/rev/f5c9e9a249637c9abd88754c8963ecb3838475cb/gfx/layers/client/TextureClient.cpp#97
![]() |
Assignee | |
Comment 1•8 years ago
|
||
I think this is an assert that uncovered a real bug, which is that we assumed SendPTextureConstructor was infallible. However after fixing that the assert now longer makes sense, because the IPDL actor might not be attached to a TextureClient. So this patch loosens the assert as well.
Assignee: nobody → dvander
Status: NEW → ASSIGNED
Attachment #8808502 -
Flags: review?(nical.bugzilla)
![]() |
Assignee | |
Comment 2•8 years ago
|
||
s/now longer/no longer/
Updated•8 years ago
|
Attachment #8808502 -
Flags: review?(nical.bugzilla) → review+
Pushed by danderson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cc2a7f082db2 Don't assume that PTextureChild allocation succeeds. (bug 1314425, r=nical)
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cc2a7f082db2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•