Closed
Bug 1314647
Opened 8 years ago
Closed 8 years ago
[e10s] <select> preserves active state when I release mouse over the list scrollbar
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
mozilla53
People
(Reporter: pauly, Assigned: enndeakin)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
[Note]:
- follow-up of bug 1256313
[Affected versions]:
- 49.0.2, 50b11, 51.0a2 (2016-11-02), 52.0a1 (2016-11-02)
[Affected platforms]:
- all
[Steps to reproduce]:
1. Open https://bugzilla.mozilla.org/attachment.cgi?id=8730207 (testcase from bug 1256313)
2. Hover mouse over the <select>'s dropmarker, hold left mouse button [drop-down list will open]
3. Hover mouse over the scrollbar
4. Release left mouse button
5. Move mouse to urlbar and click in urlbar
[Expected result]:
- Select doesn't have :active pseudoclass
[Actual result]:
- Select has :active pseudoclass
[Regression range]:
- not a recent regression, reproducible on Fx 45
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → enndeakin
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8808993 -
Flags: review?(mconley)
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8808993 [details] [diff] [review]
Clear state on mouseup
Going to fix some bugs first.
Attachment #8808993 -
Flags: review?(mconley)
Assignee | ||
Comment 3•8 years ago
|
||
I added the listeners on the window instead. This way mouseup will work outside the popup.
Attachment #8809835 -
Flags: review?(mconley)
Comment 4•8 years ago
|
||
Comment on attachment 8809835 [details] [diff] [review]
Clear state on mouseup
Review of attachment 8809835 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM - thanks Enn!
Attachment #8809835 -
Flags: review?(mconley) → review+
Comment 5•8 years ago
|
||
(Might be good to add a test for this, fwiw)
Assignee | ||
Updated•8 years ago
|
Attachment #8808993 -
Attachment is obsolete: true
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/deec8c2ba9314dadb8a4e80581f8cba467de854f
Bug 1314647, clear active state of select on mouseup, r=mconley
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a925f48bcc82
Backed out changeset deec8c2ba931 for eslint failures
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/74a7f0bc633a96ccb0b862f5ebb5366d2a134f0c
Bug 1314647, clear active state of select on mouseup, r=mconley
Comment 9•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment 11•8 years ago
|
||
Not something new, let it ride the train from 53.
Updated•2 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•