Closed
Bug 1314832
Opened 8 years ago
Closed 7 years ago
uninitialized member in MediaEngineDefault* classes
Categories
(Core :: WebRTC: Audio/Video, defect, P5)
Tracking
()
RESOLVED
DUPLICATE
of bug 1299515
People
(Reporter: jesup, Assigned: jesup)
Details
Attachments
(1 file)
|
(deleted),
patch
|
pehrsons
:
review+
|
Details | Diff | Splinter Review |
mTrackId is uninitialized in the constructor, though it doesn't really matter since it's only used for Start()ed tracks, and it's set in Start(). However, initializing it keeps the compiler and other tools happy.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8806955 -
Flags: review?(pehrson)
|
|
Assignee | |
Updated•8 years ago
|
Rank: 45
Priority: -- → P4
|
||
Updated•8 years ago
|
Attachment #8806955 -
Flags: review?(pehrson) → review+
|
||
Comment 2•7 years ago
|
||
Mass change P4->P5 to align with new Mozilla triage process.
Priority: P4 → P5
Hello,
What are the next steps needed to have this patch landing?
Thanks,
|
|
||
Updated•7 years ago
|
Flags: needinfo?(rjesup)
|
|
Assignee | |
Comment 4•7 years ago
|
||
they're initialized with TrackID mTrackID = TRACK_NONE now, per your landing in bug 1299515.
If NONE is (now) more correct than INVALID, please just close this.
Flags: needinfo?(rjesup) → needinfo?(apehrson)
|
|
||
Comment 5•7 years ago
|
||
(In reply to Randell Jesup [:jesup] from comment #4)
> they're initialized with TrackID mTrackID = TRACK_NONE now, per your landing
> in bug 1299515.
>
> If NONE is (now) more correct than INVALID, please just close this.
I think TRACK_NONE is semantically fine, thanks.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(apehrson)
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•