Closed
Bug 1315522
Opened 8 years ago
Closed 8 years ago
Marionette command-line option --addon does not work
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox52 fixed)
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: dev, Assigned: impossibus)
References
Details
(Keywords: regression)
Attachments
(1 file)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160921204512
Steps to reproduce:
Run:
/testing/marionette/harness/marionette/runner/base.py --addon=/path/to/any/addon.xpi
Actual results:
The addon doesn't get installed in the profile.
Expected results:
The addon should have been installed in the profile.
Tracking down the issue:
- BaseMarionetteArguments has the --addon option, which will map to `addon` [1].
- BaseMarionetteTestRunner accepts an `addons` parameter [2].
=> The --addon option should map to `addons` (plural), just like MozProfileCLI [3].
[1] https://dxr.mozilla.org/mozilla-central/rev/8e8b146fcb8b268e3c09b646087c6b2ef9f0af6f/testing/marionette/harness/marionette/runner/base.py#297
[2] https://dxr.mozilla.org/mozilla-central/rev/8e8b146fcb8b268e3c09b646087c6b2ef9f0af6f/testing/marionette/harness/marionette/runner/base.py#515
[3] https://dxr.mozilla.org/mozilla-central/rev/8e8b146fcb8b268e3c09b646087c6b2ef9f0af6f/testing/mozbase/mozprofile/mozprofile/cli.py#41
Comment 1•8 years ago
|
||
Thank you Martin for this bug report. As it looks like this is a regression from bug 1163801 which covered the move from optparse to argparse.
The underlying problem looks to be easy to fix. What we definitely need here is a harness unit test which makes sure that we do not regress it again.
Maja, mind mentoring that bug?
Updated•8 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(mjzffr)
Assignee | ||
Comment 2•8 years ago
|
||
The harness test is going to be a little more involved, so I'll just submit a patch for this and file a follow-up mentored bug for the test.
Mentor: mjzffr
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mjzffr
Assignee | ||
Updated•8 years ago
|
Mentor: mjzffr
Comment hidden (mozreview-request) |
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8808216 [details]
Bug 1315522 - Marionette command-line option --addon does not work;
https://reviewboard.mozilla.org/r/91068/#review90950
Attachment #8808216 -
Flags: review?(dburns) → review+
Pushed by mjzffr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b8386ff9818f
Marionette command-line option --addon does not work; r=automatedtester
Comment 6•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•