Open
Bug 1316220
Opened 8 years ago
Updated 2 years ago
[geckoview] Split o.m.g.annotations into GeckoView and Fennec parts
Categories
(GeckoView :: General, defect, P3)
GeckoView
General
Tracking
(Not tracked)
NEW
People
(Reporter: nalexander, Unassigned)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
The JNI bits should be in GeckoView, but @ReflectionTarget and @RobocopTarget should be Fennec-specific.
For @ReflectionTarget, I see a usage that is covered by Proguard (https://dxr.mozilla.org/mozilla-central/source/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoView.java#151) and two that are specific to FxA/Push integration (https://dxr.mozilla.org/mozilla-central/source/mobile/android/geckoview/src/main/java/org/mozilla/gecko/EventDispatcher.java#164). Getting rid of that reflection is really not easy, so I think it makes sense to keep the reflection (boo!) but have the reflection target be in Fennec (not GeckoView). That is, move the logic of the helper function at https://dxr.mozilla.org/mozilla-central/source/mobile/android/services/src/main/java/org/mozilla/gecko/fxa/FxAccountDeviceRegistrator.java#272 into Fennec, make that helper @ReflectionTarget, and then reflect to it in the FxA code. That'll let us move the ReflectionTarget stuff to Fennec, where it belongs.
Priority: -- → P3
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
Updated•5 years ago
|
Depends on: internal-gv-ergonomics
Updated•5 years ago
|
Blocks: remove-fennec
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•