Andreas Farre [:farre] Reporter
	Description • 8 years ago

Setting a timeout from an iframe and navigating away before it fires, then going back in history to the same document where the timeout was set should fire the queued timeout.

https://farre.github.io/tests/tests/suspend/index.html

	Andreas Farre [:farre] Reporter
	Comment 1 • 8 years ago

(In reply to Andreas Farre [:farre] from comment #0)
> Setting a timeout from an iframe and navigating away before it fires, then
> going back in history to the same document where the timeout was set should
> fire the queued timeout.
> 
> https://farre.github.io/tests/tests/suspend/index.html

That came out a bit less clear than intended. It's not the iframe that gets navigated, but the top window. The iframe is where the timeout is set though.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 2 • 8 years ago

[Tracking Requested - why for this release]:
This looks to be rather bad regression. 
Regression from bug 1300659 or bug 1303167.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 3 • 8 years ago

er, that test fails everywhere for me.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 4 • 8 years ago

Er, yes I can. I wasn't just waiting for long enough after clicking the button.

[Tracking Requested - why for this release]:
See comment 2

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 5 • 8 years ago

And the testcase is expected to fail in Chrome since it doesn't have bfcache.

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 6 • 8 years ago

Fails in my nightly without bug 1300659, so I don't think it regressed from there.  Almost certainly bug 1303167.

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 7 • 8 years ago

When we Thaw() the parent window the docshell does not know about the frozen child frame.  So the frame is not getting thawed.

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 8 • 8 years ago

This fixes it locally.  Lets see if anything else breaks:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5dbcba969fa92e44fcb2ff56e942cc0e85e5007e

I will also convert the demo site from comment 0 to a test in a P2 patch.

	Marcia Knous [:marcia]
	Comment 9 • 8 years ago

Tracking 52+ - as smaug notes in Comment 2 this is a rather bad regression.

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 10 • 8 years ago

Comment on attachment 8809059 [details] [diff] [review]
P1 Make sure we thaw child frames properly. r=smaug

This patch ensures we have setup the child docshells before Thawing the window.  This is necessary for the Thaw() to propagate down to the child frame correctly.

This fixes the test case locally and passes existing tests.

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 11 • 8 years ago

This patch adds a wpt test for the case demo'd in comment 0.  It passes with the P1 applied and fails without it.

I also included a test for the non-iframe case.  This passes with or without the P1 patch, but seemed reasonable to include.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=64a966fcfb962467482b6fffb1505d12f3f71734

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 12 • 8 years ago

Comment on attachment 8809451 [details] [diff] [review]
P2 Add wpt test to verify timers are restored after being loaded from bfcache. r=smaug

>+function delay(win, delay) {
>+  return new Promise(resolve => {
>+    win.setTimeout(_ => {
>+      resolve(win);
>+    }, delay);
>+  });
This won't work in browsers where data: urls are cross-origin, and we'll have that too


>+}
>+
>+function navigate_by_name(win, name) {
>+  win.location = make_post_back_url(name);
>+  return wait_for_message(name).then(_ => {
>+    return win;
>+  });
>+}
This should work since .location is special

>+
>+function go_back(win) {
>+  return new Promise(resolve => {
>+    win.onpagehide = e => resolve(win);
>+    win.history.back();
>+  });
>+}
but this shouldn't work
You'll need to use messaging (postMessage) for these.

	Ben Kelly [:bkelly, not reviewing] Assignee
	Comment 13 • 8 years ago

Ok.  Lets use a separate file so its same-origin, then.

	Pulsebot
	Comment 14 • 8 years ago

Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbed090b39a4
P1 Make sure we thaw child frames properly. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d1eb932fa31
P2 Add wpt test to verify timers are restored after being loaded from bfcache. r=smaug

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 15 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/dbed090b39a4
https://hg.mozilla.org/mozilla-central/rev/4d1eb932fa31