Closed
Bug 1316696
Opened 8 years ago
Closed 8 years ago
Eliminate ns{Fixed,}{C,}StringRepr from the rust bindings
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla53
People
(Reporter: nika, Assigned: nika)
References
Details
Attachments
(1 file)
(deleted),
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Now that rust 1.13 is stable drop flags are dead \o/ - this means that we can now implement Drop on #[repr(C)] types, meaning that we can hide the nsStringRepr details and directly allow using nsString<'static> in #[repr(C)] structs in place of C++'s `nsString`.
Assignee | ||
Comment 1•8 years ago
|
||
This is possible due to Rust 1.13 eliminating the Drop Flags.
I am not confident whether or not Rust 1.13 (which is only recently stable) is avaliable in infra yet. If it is not, this patch will have to be blocked on that.
MozReview-Commit-ID: AMwAUq82vMo
Attachment #8809944 -
Flags: review?(nfroyd)
Assignee | ||
Updated•8 years ago
|
Summary: Allow rust's nsString bindings to be used in FFI → Eliminate ns{Fixed,}{C,}StringRepr from the rust bindings
Comment 2•8 years ago
|
||
(In reply to Michael Layzell [:mystor] [:mrl] from comment #1)
> I am not confident whether or not Rust 1.13 (which is only recently stable)
> is avaliable in infra yet. If it is not, this patch will have to be blocked
> on that.
We not only need it to be in infra, but we also need to update configure to require Rust 1.13.
Depends on: 1316751
Comment 3•8 years ago
|
||
We can't require 1.13 on all platforms, it has ARM codegen issues.
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #3)
> We can't require 1.13 on all platforms, it has ARM codegen issues.
This is a good point - we won't be able to land this patch until after a 1.13.1
Updated•8 years ago
|
Attachment #8809944 -
Flags: review?(nfroyd) → review+
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b368ec57dc57
Eliminate ns{Fixed,}{C,}StringRepr from the rust bindings, r=froydnj
Comment 6•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Assignee | ||
Comment 7•8 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/f50ae3e4924d028b4d7488833999fd7012782727 because of bug 1320425, and rustc 1.13 not being required yet.
We can reland this when we are comfortable with requiring a minimum rustc=1.13 in order to build firefox.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 8•8 years ago
|
||
backout bugherder |
backout also from central
https://hg.mozilla.org/mozilla-central/rev/f50ae3e4924d
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e259fa04f68
Eliminate ns{Fixed,}{C,}StringRepr from the rust bindings, r=froydnj
Comment 10•8 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Comment 11•8 years ago
|
||
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/56b122662f91
Eliminate ns{Fixed,}{C,}StringRepr from the rust bindings, r=froydnj for being the wrong commit backed out a=backout
Comment 12•8 years ago
|
||
Backout by kwierso@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/f2bccdc9fe7e
Backed out changeset 4e259fa04f68 for asserts in DocAccessibleParent.cpp a=backout
You need to log in
before you can comment on or make changes to this bug.
Description
•