Alice0775 White Reporter
	Description • 8 years ago

[Tracking Requested - why for this release]:

+++ This bug was initially created as a clone of Bug #1314802 +++

<select> dropdown list is not respect browser zoom level, So It is too hard to read/distinguish them.

Steps To Reproduce:
1. Open attached
2. Expand drop down
3. Zoom up

Actual Results:
Emoji font size is too small for me. So It is too hard to read/distinguish them.

Expected Results:
<select> dropdown list is not respect browser zoom level.

	Alice0775 White Reporter
	Comment 4 • 8 years ago

Regression window:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=f03e2740d604d339ed553dad62a3fc54c317f8fa&tochange=83461556cda59e8bcd54f09b9263e3202ce01dc2

Regressed by: 83461556cda5	Mark Golbeck — Bug 1091592 - Improve style of select dropdowns, including adding more padding for touch-enabled devices. r=jaws

BTW,
Similar bugs existed in the past(Bug 1128162).
But no automated test is provided :( The product lacks reliability :(

	Dão Gottwald [:dao]
	Comment 6 • 8 years ago

Comment on attachment 8810507 [details]
Bug 1316722 - [e10s] <select> dropdown list should handle Full/Text Zoom on Windows.

Can you please document these seemingly magic numbers?

It looks like this patch will still reduce the font size from the system default. We shouldn't do that. (Also "font: message-box;" seems redundant.)

	Mike Conley (:mconley) (:⚙️)
	Comment 7 • 8 years ago
mozreview-review

Comment on attachment 8810507 [details]
Bug 1316722 - [e10s] <select> dropdown list should handle Full/Text Zoom on Windows.

https://reviewboard.mozilla.org/r/92788/#review93260

(In reply to Dão Gottwald [:dao] from comment #6)
> Comment on attachment 8810507 [details]
> Bug 1316722 - [e10s] \<select\> dropdown list should handle Full/Text Zoom on
> Windows.
> 
> Can you please document these seemingly magic numbers?

I concur - these are pretty mysterious.

> 
> It looks like this patch will still reduce the font size from the system
> default. We shouldn't do that.

Also in agreement there. Or was changing the font size part of [the original spec](https://bug1091592.bmoattachments.org/attachment.cgi?id=8776005) that I'm not seeing?

> (Also "font: message-box;" seems redundant.)

Is it? We're only overriding the font-size rule, but still using the rest of the font shorthand rules... or am I missing something?

	Dão Gottwald [:dao]
	Comment 8 • 8 years ago

(In reply to Mike Conley (:mconley) from comment #7)
> > It looks like this patch will still reduce the font size from the system
> > default. We shouldn't do that.
> 
> Also in agreement there. Or was changing the font size part of [the original
> spec](https://bug1091592.bmoattachments.org/attachment.cgi?id=8776005) that
> I'm not seeing?

For accessibility reasons, please push back if this is part of some spec.

> > (Also "font: message-box;" seems redundant.)
> 
> Is it? We're only overriding the font-size rule, but still using the rest of
> the font shorthand rules... or am I missing something?

I didn't dig further to see if something more complex is going on here, but as far as I can tell the popup lives in browser.xul from where it should inherit font stuff like other popups do.

	Mike Conley (:mconley) (:⚙️)
	Comment 11 • 8 years ago
mozreview-review

Comment on attachment 8810507 [details]
Bug 1316722 - [e10s] <select> dropdown list should handle Full/Text Zoom on Windows.

https://reviewboard.mozilla.org/r/92788/#review94232

::: browser/themes/windows/browser.css:2702
(Diff revision 2)
> -  padding-top: 11px;
> -  padding-bottom: 11px;
> +  padding-top: .9167em;
> +  padding-bottom: .9167em;

I guess we need a similar comment here about the 11/12 ratio?

	Pulsebot
	Comment 13 • 8 years ago

Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e6d8617b5b7
[e10s] <select> dropdown list should handle Full/Text Zoom on Windows. r=mconley

	Jared Wein [:jaws] (please needinfo? me) Assignee
	Comment 14 • 8 years ago

Comment on attachment 8810507 [details]
Bug 1316722 - [e10s] <select> dropdown list should handle Full/Text Zoom on Windows.

Approval Request Comment
[Feature/regressing bug #]: bug 1091592
[User impact if declined]: full zoom on pages won't adjust select popups
[Describe test coverage new/current, TreeHerder]: manual testing, visual change only
[Risks and why]: low risk, only CSS
[String/UUID change made/needed]: none

	Carsten Book [:Tomcat]
	Comment 15 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/2e6d8617b5b7

	Julien Cristau [:jcristau]
	Comment 16 • 8 years ago

Comment on attachment 8810507 [details]
Bug 1316722 - [e10s] <select> dropdown list should handle Full/Text Zoom on Windows.

style fix for select with e10s, take in aurora52

	Carsten Book [:Tomcat]
	Comment 17 • 8 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/f0cbef669a19