Closed
Bug 1316869
Opened 8 years ago
Closed 8 years ago
Custom tabs: Adapt text color based on toolbar color
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox52 fixed)
RESOLVED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: sebastian, Assigned: droeh)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
sebastian
:
review+
|
Details | Diff | Splinter Review |
Bug 1279278 introduced a colored toolbar for custom tabs. However the text color does not adapt. Whenever a custom tab with a very light color is opened the white text is almost unreadable.
|
Assignee | |
Comment 1•8 years ago
|
||
This is an easy enough fix, I added ColorUtil functionality that picks black or white as a readable text color based on background color.
|
Reporter | |
Updated•8 years ago
|
Attachment #8809836 -
Flags: review?(s.kaspari) → review+
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0114eda62ce2
Choose black or white title text color for custom tabs toolbar based on background color. r=sebastian
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2f9a7cdcb51
checkstyle fixes a=me
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0114eda62ce2
https://hg.mozilla.org/mozilla-central/rev/b2f9a7cdcb51
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
|
Reporter | |
Updated•8 years ago
|
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•