Dave Townsend [:mossop] Assignee
	Description • 8 years ago

A number of rules and easily be turned on with autofix

	Brian Grinstead [:bgrins]
	Comment 11 • 8 years ago
mozreview-review

Comment on attachment 8809852 [details]
Bug 1316882: Turn on func-call-spacing eslint rule.

https://reviewboard.mozilla.org/r/92352/#review92464

	Jared Wein [:jaws] (please needinfo? me)
	Comment 14 • 8 years ago
mozreview-review

Comment on attachment 8809855 [details]
Bug 1316882: Turn on space-before-function-paren eslint rule (browser).

https://reviewboard.mozilla.org/r/92358/#review92750

	Jared Wein [:jaws] (please needinfo? me)
	Comment 15 • 8 years ago
mozreview-review

Comment on attachment 8809851 [details]
Bug 1316882: Turn on space-infix-ops eslint rule.

https://reviewboard.mozilla.org/r/92350/#review92758

::: toolkit/.eslintrc.js:178
(Diff revision 2)
>  
>      // No space padding in parentheses
>      // "space-in-parens": ["error", "never"],
>  
>      // Require spaces around operators
> -    // "space-infix-ops": "error",
> +    "space-infix-ops": "error",

I think we should include {"int32Hint": true} here since it's likely there is a usage of a|0 somewhere in our JS code and we don't normally write it as `a | 0`.

	Jared Wein [:jaws] (please needinfo? me)
	Comment 22 • 8 years ago
mozreview-review

Comment on attachment 8809977 [details]
Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit).

https://reviewboard.mozilla.org/r/92454/#review92786

::: toolkit/mozapps/extensions/AddonManager.jsm:2622
(Diff revision 2)
> -      nextObject: function getAddonsWithOperationsByTypes_nextObject
> +      nextObject: function getAddonsWithOperationsByTypes_nextObject(aCaller, aProvider) {
> -                           (aCaller, aProvider) {
>          callProviderAsync(aProvider, "getAddonsWithOperationsByTypes", aTypes,
> -                          function getAddonsWithOperationsByTypes_concatAddons
> +                          function getAddonsWithOperationsByTypes_concatAddons(aProviderAddons) {
> -                                   (aProviderAddons) {

It looks like both of these were wrapped to the next line to keep them under 80chars. We should be able to drop the function names since they're not referenced and just make them anonymous.

	Matthew N. [:MattN]
	Comment 23 • 8 years ago
mozreview-review

Comment on attachment 8809854 [details]
Bug 1316882: Turn on space-unary-ops eslint rule.

https://reviewboard.mozilla.org/r/92356/#review92872

Thanks

	Mark Banner (:standard8)
	Comment 24 • 8 years ago

Comment on attachment 8809851 [details]
Bug 1316882: Turn on space-infix-ops eslint rule.

Jared, can you take care of this for me please?

	Jared Wein [:jaws] (please needinfo? me)
	Comment 25 • 8 years ago
mozreview-review

Comment on attachment 8809851 [details]
Bug 1316882: Turn on space-infix-ops eslint rule.

https://reviewboard.mozilla.org/r/92350/#review93230

::: toolkit/.eslintrc.js:178
(Diff revision 3)
>  
>      // No space padding in parentheses
>      // "space-in-parens": ["error", "never"],
>  
>      // Require spaces around operators
> -    // "space-infix-ops": "error",
> +    "space-infix-ops": ["error", { "int32Hint": false }],

This still needs to change to { "in32Hint": true }

	:Felipe Gomes (needinfo for replies!)
	Comment 26 • 8 years ago
mozreview-review

Comment on attachment 8809853 [details]
Bug 1316882: Turn on rest-spread-spacing eslint rule.

https://reviewboard.mozilla.org/r/92354/#review93264

	Pulsebot
	Comment 27 • 8 years ago

Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a958562f3d67
Turn on space-infix-ops eslint rule. r=jaws
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e3138495bcf
Turn on func-call-spacing eslint rule. r=bgrins
https://hg.mozilla.org/integration/mozilla-inbound/rev/519f9207ae90
Turn on rest-spread-spacing eslint rule. r=felipe
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1fa4eab9a05
Turn on space-unary-ops eslint rule. r=MattN
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfa1b55da2b1
Turn on space-before-function-paren eslint rule (browser). r=jaws
https://hg.mozilla.org/integration/mozilla-inbound/rev/4873321befff
Turn on space-before-function-paren eslint rule (toolkit). r=jaws

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 28 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/a958562f3d67
https://hg.mozilla.org/mozilla-central/rev/5e3138495bcf
https://hg.mozilla.org/mozilla-central/rev/519f9207ae90
https://hg.mozilla.org/mozilla-central/rev/e1fa4eab9a05
https://hg.mozilla.org/mozilla-central/rev/dfa1b55da2b1
https://hg.mozilla.org/mozilla-central/rev/4873321befff