Closed
Bug 1316957
Opened 8 years ago
Closed 8 years ago
Include windows.configure conditionally instead of using depends_win
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: glandium, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8809938 [details]
Bug 1316957 - Include windows.configure conditionally instead of using @depends_win.
https://reviewboard.mozilla.org/r/92408/#review92514
::: build/moz.configure/windows.configure:93
(Diff revision 2)
> def valid_windows_sdk_dir_result(value):
> if value:
> return '0x%04x in %s' % (value.version, quote(value.path))
>
> -@depends_win(c_compiler, windows_sdk_dir, valid_windows_version,
> +@depends(c_compiler, windows_sdk_dir, valid_windows_version,
> 'WINDOWSSDKDIR')
This indendation is off now.
Attachment #8809938 -
Flags: review?(cmanchester) → review+
| Comment hidden (mozreview-request) |
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/2b174353e76a
Include windows.configure conditionally instead of using @depends_win. r=chmanchester
Glandium asked for this to be backed out, so https://hg.mozilla.org/integration/autoland/rev/b45288800745
Flags: needinfo?(mh+mozilla)
| Comment hidden (mozreview-request) |
|
Reporter | |
Updated•8 years ago
|
Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/d63d083ab767
Include windows.configure conditionally instead of using @depends_win. r=chmanchester
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
|
Reporter | |
Comment 10•8 years ago
|
||
Backed out on aurora. See bug 1322025.
https://hg.mozilla.org/releases/mozilla-aurora/rev/cceb7f61ef17d0c10d42f4e4a9820d40cc46528d
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•