Closed
Bug 1317182
Opened 8 years ago
Closed 8 years ago
Fix button text alignment of Preference button and Remove button in about:preferences#containers
Categories
(Firefox :: Settings UI, defect, P3)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
People
(Reporter: magicp.jp, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [userContextId][domsecurity-backlog])
Attachments
(3 files)
Steps to Reproduce:
1. Start Nightly
2. Go to about:preferences#containers
3. Conform button text alignment of Preference button and Remove button
Actual Results:
Button text alignment is in the left side.
(* In the attached image, button width is changed for easy to see)
Expected Results:
Button text alignment is center.
Blocks: 1267916
status-firefox53:
--- → affected
Comment 1•8 years ago
|
||
It looks like this only affects Win/Ubuntu. The text within the buttons seems correctly aligned under macOS 10.12.2.
Blocks: ContextualIdentity
OS: Unspecified → All
Hardware: Unspecified → All
Whiteboard: [userContextId][domsecurity-backlog]
(In reply to Kamil Jozwiak [:kjozwiak] from comment #1)
> It looks like this only affects Win/Ubuntu. The text within the buttons
> seems correctly aligned under macOS 10.12.2.
You are wrong. It affects on macOS 10.12.2.
Comment 3•8 years ago
|
||
> You are wrong. It affects on macOS 10.12.2.
Hmmm, I can't seem to reproduce it on macOS :/ I've even changed the padding [1] and it seems like the text is correctly being aligned. With Ubuntu/Win, you can tell off that bat that the "Remove" text isn't being correctly aligned but in macOS, it seems like it's correctly being aligned [2].
CC'ing Jonathan as well as he's the one that usually works on container UI bugs.
[1] editedPadding.png
[2] default.png
Comment 4•8 years ago
|
||
(In reply to Kamil Jozwiak [:kjozwiak] from comment #4)
> Created attachment 8819918 [details]
> default.png
I understand, you should edit button width. (not padding)
For example, you can see different padding-left/right of the remove button in default.png.
Updated•8 years ago
|
Priority: -- → P3
Comment 6•8 years ago
|
||
This gets fixed by bug 1315458.
I confirmed this bug was fixed on 53. Thanks!
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•