Closed Bug 1317185 Opened 8 years ago Closed 8 years ago

Cannot reflect usercontext identity color immediately at existing tab even if changing identity color

Categories

(Firefox :: Settings UI, defect, P3)

defect

Tracking

()

VERIFIED FIXED
Firefox 53
Tracking Status
firefox52 --- affected
firefox53 --- verified

People

(Reporter: magicp.jp, Assigned: baku)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [userContextId][domsecurity-backlog])

Attachments

(2 files)

Steps to Reproduce: 1. Start Nightly 2. Open new container tab (e.g. Personal, identity color is blue) 3. Go to about:preferences#containers 4. Change identity color from blue to yellow Actual Results: Cannot reflect usercontext identity color immediately at existing tab even if changing identity color. Actual Results: Reflect usercontext identity color immediately.
Blocks: 1267916
I ran into this several times as well. It looks like the colour/indicators are correctly being changed under the awesome bar, but the tab highlights are not immediately being changed. If you move the tab into it's own separate window, the colour does end up changing. Platforms: * macOS 10.12.1 -> affected * Ubuntu 16.04.1 LTS -> affected * Win 10 x64 -> affected
Has STR: --- → yes
OS: Unspecified → All
Hardware: Unspecified → All
Whiteboard: [userContextId][domsecurity-backlog]
Priority: -- → P3
Attached patch color.patch (deleted) — Splinter Review
Assignee: nobody → amarchesini
Attachment #8817196 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8817196 [details] [diff] [review] color.patch Review of attachment 8817196 [details] [diff] [review]: ----------------------------------------------------------------- r=me Can you file a followup to switch to weak ref observers?
Attachment #8817196 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2ff0d7460eb6 Propagate contextual-identity-updated notification when an ContextualIdentity is modified, r=gijs
Blocks: 1322387
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
I have reproduced this bug with Nightly 52.0a1 (2016-11-13) on Windows 8.1 , 64 Bit ! Build ID 20161113030203 User Agent Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 This bug's fix is Verified with latest Nightly ! Build ID 20161208075029 User Agent Mozilla/5.0 (Windows NT 6.3; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0 [bugday-20161207]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: