This appears to be an oversized web form checkbox. Clicking on it doesn't change the state though.

Huh, first of all this checkbox should not be shown. I can reproduce on Nightly, I think that regressed with bug 1309316. Should be easy to fix. However, I can't reproduce > Clicking on it doesn't change the state though. and I'm also confused that you don't seem to have the green/gray "toggle" next to the checkbox. Can you check for errors in the page console and the browser console?

Duplicate of bug #1317795 ? BTW I'm able to change status of Tracking Protection using both checkboxes in Private Mode (Windows 7 [64bit] + Nightly [64it]).

> Duplicate of bug #1317795 ? Looks like it, thanks!

Actually, I think this is kinda separate from bug 1317795. The checkbox is _never_ supposed to be visible. I think the situation jimm was in was occurs when privacy.trackingprotection.enabled is set to true, which enables global tracking protection. I am easily able to reproduce the issue with that pref set. I think I can fix this separately from the checkbox restyling that's going to occur elsewhere once bug 418833 lands.

(In reply to Mike Conley (:mconley) from comment #4) > I think the situation jimm was in was occurs when > privacy.trackingprotection.enabled is set to true, which enables global > tracking protection. I am easily able to reproduce the issue with that pref > set. > > I think I can fix this separately from the checkbox restyling that's going > to occur elsewhere once bug 418833 lands. Ah, good find. I don't think that this needs any more fixing except hiding the checkbox though :)

Comment on attachment 8812490 [details] Bug 1317804 - Hide the checkbox toggle in about:privatebrowsing. https://reviewboard.mozilla.org/r/94216/#review94402 Thanks, this seems to work fine! ::: browser/themes/shared/privatebrowsing/aboutPrivateBrowsing.css:142 (Diff revision 1) > > +.toggle-input { > + opacity: 0; > + width: 0; > + pointer-events: none; > + position: absolute; A minor note: As a relative newcomer to this code, I had to spend some time reading through blame and old bugs to find out why exactly this is hidden like that and not just using "display:none" (apparently to preserve keyboard focus). Can you add a really short comment explaining that? The recent changes will make it much harder to get the blame info in the future.

Comment on attachment 8812490 [details] Bug 1317804 - Hide the checkbox toggle in about:privatebrowsing. https://reviewboard.mozilla.org/r/94216/#review94402 > A minor note: > > As a relative newcomer to this code, I had to spend some time reading through blame and old bugs to find out why exactly this is hidden like that and not just using "display:none" (apparently to preserve keyboard focus). > > Can you add a really short comment explaining that? The recent changes will make it much harder to get the blame info in the future. Thanks for the review! That's a really good call - thanks johannh! (And welcome back! :D)

Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9b5e7c9b5c8c Hide the checkbox toggle in about:privatebrowsing. r=johannh

Comment on attachment 8812490 [details] Bug 1317804 - Hide the checkbox toggle in about:privatebrowsing. Approval Request Comment [Feature/regressing bug #]: Bug 1309316. [User impact if declined]: A non-native checkbox (sometimes non-functional in a non-default case) will be displayed in about:privatebrowsing. [Describe test coverage new/current, TreeHerder]: Testing was manual, but this is a page styling thing, so that's about par for the course here. [Risks and why]: Very low risk. We're just hiding the checkbox. [String/UUID change made/needed]: None.

Comment on attachment 8812490 [details] Bug 1317804 - Hide the checkbox toggle in about:privatebrowsing. styling regression fix in about:privatebrowsing, take in aurora52

I have reproduced this bug with Nightly 53.0a1 (2016-11-15) on Windows 8.1 , 64 Bit ! Build ID 20161115030213 User Agent Mozilla/5.0 (Windows NT 6.3; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0 This bug's fix is Verified with latest Aurora and latest Nightly ! Build ID 20161206004003 User Agent Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 Build ID 20161205030204 User Agent Mozilla/5.0 (Windows NT 6.3; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0 [bugday-20161207]

Thanks!

[bugday-20170104] Bug verified

[bugday-20170104] Bug verified

[bugday-1317804] bug verified sorry about previous comment