Closed
Bug 1318218
Opened 8 years ago
Closed 8 years ago
Remove PermissionsTable
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
baku
:
review+
jryans
:
review+
|
Details | Diff | Splinter Review |
This also removes the WebIDE UI for viewing the permissions table.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8811564 -
Flags: review?(jryans)
Attachment #8811564 -
Flags: review?(amarchesini)
Updated•8 years ago
|
Attachment #8811564 -
Flags: review?(amarchesini) → review+
Comment on attachment 8811564 [details] [diff] [review]
Remove PermissionsTable
Review of attachment 8811564 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for doing this clean up!
::: devtools/server/actors/device.js
@@ +56,5 @@
> let dataURL = canvas.toDataURL("image/png");
> return new LongStringActor(this.conn, dataURL);
> },
>
> getRawPermissionsTable: function () {
Seems like this whole method can be removed, doesn't seem to have much purpose anymore.
You should remove the `getRawPermissionsTable` part from http://searchfox.org/mozilla-central/source/devtools/shared/specs/device.js#15 (which marks the methods that go over the wire to devices).
Attachment #8811564 -
Flags: review?(jryans) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/592927e727fd
Remove PermissionsTable; r=baku,jryans
Comment 5•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•