Closed
Bug 1318764
Opened 8 years ago
Closed 8 years ago
Get rid of sync GetLookAndFeelCache, and send the cache with the GetXPCOMProcessAttributes message instead
Categories
(Core :: DOM: Content Processes, defect)
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: mconley, Unassigned)
References
Details
Attachments
(1 file)
This coalesces two sync messages into one.
| Comment hidden (mozreview-request) |
|
Reporter | |
Updated•8 years ago
|
|
|
Reporter | |
Updated•8 years ago
|
Attachment #8812322 -
Flags: review?(jmathies) → review?(wmccloskey)
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8812322 [details]
Bug 1318764 - Get rid of GetLookAndFeelCache sync IPC message, and send cache with GetXPCOMProcessAttributes instead.
https://reviewboard.mozilla.org/r/94114/#review95062
Please note that InfallibleTArray and nsTArray are the same. I'm not sure which one is preferred now. Maybe check with Nathan.
Attachment #8812322 -
Flags: review?(wmccloskey) → review+
|
|
Reporter | |
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8812322 [details]
Bug 1318764 - Get rid of GetLookAndFeelCache sync IPC message, and send cache with GetXPCOMProcessAttributes instead.
https://reviewboard.mozilla.org/r/94114/#review95068
::: dom/ipc/ContentChild.h:634
(Diff revision 1)
> InfallibleTArray<mozilla::dom::FontFamilyListEntry>&
> SystemFontFamilyList() {
> return mFontFamilies;
> }
>
> + InfallibleTArray<LookAndFeelInt>&
Thanks!
Ah, according to froydnj, nsTArray is preferred over InfallibleTArray. I'll update the patch with that change before landing.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fec5699c5c50
Get rid of GetLookAndFeelCache sync IPC message, and send cache with GetXPCOMProcessAttributes instead. r=billm
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•