Closed
Bug 1318910
Opened 8 years ago
Closed 8 years ago
urlbar.extension.label "Extension:" needs a localization comment
Categories
(WebExtensions :: Frontend, defect, P2)
WebExtensions
Frontend
Tracking
(firefox52 fixed, firefox53 fixed)
RESOLVED
FIXED
mozilla53
People
(Reporter: flod, Assigned: mattw)
References
Details
(Whiteboard: triaged)
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
kmag
:
review+
jcristau
:
approval-mozilla-aurora+
|
Details |
https://hg.mozilla.org/mozilla-central/diff/02cecde2f137/browser/locales/en-US/chrome/browser/browser.dtd
There's no way to tell what "Extension" means here without a localization comment. It could be a TLD, or an add-on.
Not sure if someone wants to keep this as a good first bug for new contributors.
Updated•8 years ago
|
Assignee: nobody → mwein
Priority: -- → P2
Whiteboard: triaged
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8812911 [details]
Bug 1318910: Provide a localization comment for urlbar.extension.label
https://reviewboard.mozilla.org/r/94438/#review94726
::: browser/locales/en-US/chrome/browser/browser.dtd:395
(Diff revision 1)
> +<!-- LOCALIZATION NOTE (urlbar.extension.label): Used to indicate
> + that a selected autocomplete entry is provided by an Add-on. -->
One line please. And s/Add-on/extension/
Attachment #8812911 -
Flags: review?(kmaglione+bmo) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6ad1f8d07ea2
Provide a localization comment for urlbar.extension.label r=kmag
Keywords: checkin-needed
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8812911 [details]
Bug 1318910: Provide a localization comment for urlbar.extension.label
I'll go ahead and ask for aurora approval, hopefully we'll avoid errors.
Approval Request Comment
[Feature/regressing bug #]: -
[User impact if declined]: lack of comment might cause wrong translations
[Describe test coverage new/current, TreeHerder]: -
[Risks and why]: none
[String/UUID change made/needed]: only a comment added, so you'll need l10n=(reldriver) to land
Attachment #8812911 -
Flags: approval-mozilla-aurora?
Comment 6•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment 7•8 years ago
|
||
Comment on attachment 8812911 [details]
Bug 1318910: Provide a localization comment for urlbar.extension.label
add l10n comment, take in aurora52
Attachment #8812911 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•8 years ago
|
||
bugherder uplift |
status-firefox52:
--- → fixed
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•