Closed
Bug 1319082
Opened 8 years ago
Closed 7 years ago
Send Tab shows disconnected devices
Categories
(Firefox for iOS :: Sync, defect, P1)
Tracking
()
RESOLVED
DUPLICATE
of bug 1386017
Iteration:
1.28
Tracking | Status | |
---|---|---|
fxios | 9.0 | --- |
People
(Reporter: rfeeley, Assigned: justindarc)
References
(Depends on 1 open bug)
Details
(Whiteboard: [MobileCore][FxA][8.2][SendTab])
Attachments
(1 file)
(deleted),
image/png
|
Details |
STEPS TO REPRODUCE
1. Sync several devices
2. Send a tab from iOS
3. Disconnect a device in fxa/settings
4. Wait any period of time, even weeks
5. Send a tab
EXPECTED RESULTS
- List of connected devices is shown
ACTUAL RESULTS
- List of all current and previously connected devices is shown
Comment 1•8 years ago
|
||
On step 3, how are you disconnecting the device?
If on an Android device: Bug 963446.
If on an iOS device: Bug 1168690.
If through Device Manager or something else… well, they can't actually remove data from your Sync account!
Devices _should_ age out of the device list after three weeks. It's quite possible that on iOS we don't locally obey that TTL, but I don't see a bug on file.
In short: this is currently expected behavior, and nobody has been sufficiently motivated to do the work needed to fix it.
Updated•8 years ago
|
Flags: needinfo?(rfeeley)
Comment 2•8 years ago
|
||
> If through Device Manager or something else… well, they can't actually remove data from your Sync account!
Is this because we haven't implemented the device registration API on iOS to properly identify a user's device?
> Devices _should_ age out of the device list after three weeks. It's quite possible that on iOS we don't locally obey that TTL, but I don't see a bug on file.
I'll investigate and see if we need a bug on file for this.
Comment 3•8 years ago
|
||
(In reply to Stephan Leroux [:sleroux] from comment #2)
> > If through Device Manager or something else… well, they can't actually remove data from your Sync account!
>
> Is this because we haven't implemented the device registration API on iOS to
> properly identify a user's device?
No. AIUI, the FxA web device manager simply doesn't know enough to reach into the user's sync account and delete the corresponding record.
The first two bugs I linked to are about us not deleting the data ourselves.
Reporter | ||
Comment 4•8 years ago
|
||
The device list on the web is up-to-date. Do you think this is still an FxA issue? I'll loop our team in if so.
Flags: needinfo?(rfeeley) → needinfo?(rnewman)
Comment 5•8 years ago
|
||
Only if you deleted the device through the web, and expected it to be removed from Sync.
If you just disconnected your FxA on Android or iOS, then this bug is a nice simple dupe -- see Comment 1.
Flags: needinfo?(rnewman)
Comment 6•8 years ago
|
||
> AIUI, the FxA web device manager simply doesn't know enough to reach into the user's sync account
> and delete the corresponding record.
This is accurate, and FxA doesn't have enough information to do this correctly even if it wanted to.
> Only if you deleted the device through the web, and expected it to be removed from Sync.
But this is a totally reasonable expectation for a user to have, so we should figure out a path forward here.
My tentative proposal is that we should start treating the FxA device list as canonical - if you're not in the FxA device list, you're not connected to sync and shouldn't show up in any of the client-side sync devices UI.
* FxA will now auto-create a "placeholder" device record for sync clients that don't know how to do it themselves, so there's minimal risk of a device being missing from the FxA list.
* It's much easier for the user to manage the FxA list than the one in the clients collection in sync, meaning users can effectively purge their old devices.
Of course, I've no sense of how complicated that might get for the client-side code! But it seems like the "right" thing to work towards.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
Iteration: --- → 1.25
tracking-fxios:
--- → 8.1+
Priority: -- → P1
Assignee | ||
Comment 7•7 years ago
|
||
(In reply to Ryan Kelly [:rfkelly] from comment #6)
> My tentative proposal is that we should start treating the FxA device list
> as canonical - if you're not in the FxA device list, you're not connected to
> sync and shouldn't show up in any of the client-side sync devices UI.
>
Now that we're storing `fxaDeviceId` locally, this is my plan to resolve this bug.
Assignee | ||
Updated•7 years ago
|
Whiteboard: [MobileCore][FxA]
Assignee | ||
Updated•7 years ago
|
Updated•7 years ago
|
Whiteboard: [MobileCore][FxA] → [MobileCore][FxA][8.2]
Updated•7 years ago
|
Iteration: 1.25 → 1.26
Comment 9•7 years ago
|
||
Moving to 9.0, but can be moved back to 8.x if there is a patch.
Updated•7 years ago
|
Whiteboard: [MobileCore][FxA][8.2] → [MobileCore][FxA][8.2][SendTab[
Assignee | ||
Updated•7 years ago
|
Whiteboard: [MobileCore][FxA][8.2][SendTab[ → [MobileCore][FxA][8.2][SendTab]
Updated•7 years ago
|
Iteration: 1.26 → 1.27
Updated•7 years ago
|
Iteration: 1.27 → 1.28
Assignee | ||
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•