Closed
Bug 1319227
Opened 8 years ago
Closed 8 years ago
Process ObjdirFiles / ObjdirPreprocessedFiles in the tup backend
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: mshal, Unassigned)
References
Details
Attachments
(1 file)
These are similar to the FinalTargetFiles objects, so they should be fairly straightforward to implement.
|
Reporter | |
Comment 1•8 years ago
|
||
Bug 1319637 turned these into FinalTargetFiles directly, so we just need to slightly fix up the FinalTargetFiles processing and we'll get these as well.
| Comment hidden (mozreview-request) |
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8817102 [details]
Bug 1319227 - Support ObjdirFiles in tup;
https://reviewboard.mozilla.org/r/97534/#review97936
::: python/mozbuild/mozbuild/backend/tup.py
(Diff revision 1)
> -
> for path, files in obj.files.walk():
> backend_file = self._get_backend_file(mozpath.join(target, path))
> for f in files:
> assert not isinstance(f, RenamedSourcePath)
> - dest = mozpath.join(reltarget, path, f.target_basename)
I guess this was already unused, hm.
Attachment #8817102 -
Flags: review?(cmanchester) → review+
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c698b01dfe8
Support ObjdirFiles in tup; r=chmanchester
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•