Closed
Bug 1319469
Opened 8 years ago
Closed 8 years ago
Port bug 1305453 [Prevent non-esr stand alone installers from installing on XP/Vista (Fx53 and up) ]
Categories
(Thunderbird :: Installer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 53.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(2 files)
From bug 1305453:
(In reply to Jim Mathies [:jimm] from comment #0)
> We plan to eol XP/Vista by first moving those users out to ESR 52. Once 52
> merges to aurora, we should land changes to the stand alone installer to
> prevent install by XP and Vista users. Initially there shouldn't be an issue
> with running but eventually we'll import a system dependency that will break
> browser startup.
Assignee | ||
Comment 1•8 years ago
|
||
FX changesets as reference:
https://hg.mozilla.org/mozilla-central/rev/af88a04128f6
https://hg.mozilla.org/mozilla-central/rev/86a19f0dfa67
Assignee | ||
Comment 2•8 years ago
|
||
This is a simple port of the FX patch.
Jörg, I know you are not a installer specialist. But do we have one? I have nothing added, only ported.
Aryx, can you check all is okay? Thanks.
Attachment #8813369 -
Flags: review?(jorgk)
Attachment #8813369 -
Flags: feedback?(aryx.bugmail)
Assignee | ||
Comment 3•8 years ago
|
||
Error message on XP. By clicking on "Ok" I get the system requirements page of TB 45.5.0. But in FX bug there was the page of FX 50 and not 53. So this should be okay.
Assignee | ||
Comment 4•8 years ago
|
||
Forgot the link to try build for the installer: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a1588d0c9330a2a5b9f2aabe96765ad93de68da8
The orange is because of check-sync-dir.
Comment 5•8 years ago
|
||
Comment on attachment 8813369 [details] [diff] [review]
noXPInstaller.patch
Review of attachment 8813369 [details] [diff] [review]:
-----------------------------------------------------------------
Philipp (:Fallen) is build peer, I don't know whether that covers installers.
I checked that you merged the two FF changesets correctly. I would be good to actually try an installer ;-)
r=jorgk.
Attachment #8813369 -
Flags: review?(jorgk) → review+
Assignee | ||
Comment 6•8 years ago
|
||
You can find the installer from the try build: https://archive.mozilla.org/pub/thunderbird/try-builds/richard.marti@gmail.com-a1588d0c9330a2a5b9f2aabe96765ad93de68da8/
Comment 7•8 years ago
|
||
Comment on attachment 8813369 [details] [diff] [review]
noXPInstaller.patch
Can test the Try installers tomorrow (on XP).
Attachment #8813369 -
Flags: feedback?(aryx.bugmail) → feedback+
Assignee | ||
Comment 8•8 years ago
|
||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
Comment 9•8 years ago
|
||
Thanks, I'll try a Daily installer later today. I hope we get more feedback from Sebastian.
Assignee | ||
Comment 10•8 years ago
|
||
I tried the installer on XP. The screenshot (attachment 8813371 [details]) is from this try.
Comment 11•8 years ago
|
||
Thanks, attempt to install it on Win XP created the same popup like in comment 10.
You need to log in
before you can comment on or make changes to this bug.
Description
•