Closed
Bug 1319539
Opened 8 years ago
Closed 8 years ago
Remove leftover chrome://browser/skin/syncProgress-*.png files
Categories
(Firefox :: Sync, defect, P2)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: florian, Assigned: pass2pawan)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
(deleted),
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
Bug 1201331 (https://hg.mozilla.org/mozilla-central/rev/661a531f5dee) removed references to these files without removing them from the tree:
chrome://browser/skin/syncProgress-menuPanel.png linux,mac,windows
chrome://browser/skin/syncProgress-menuPanel@2x.png linux,mac,windows
chrome://browser/skin/syncProgress-toolbar-XPVista7.png windows
chrome://browser/skin/syncProgress-toolbar-XPVista7@2x.png windows
chrome://browser/skin/syncProgress-toolbar-inverted.png linux,mac,windows
chrome://browser/skin/syncProgress-toolbar-inverted@2x.png mac,windows
chrome://browser/skin/syncProgress-toolbar.png linux,mac,windows
chrome://browser/skin/syncProgress-toolbar@2x.png mac,windows
Updated•8 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•8 years ago
|
||
is the bug simply removing those files ?
Comment 2•8 years ago
|
||
(In reply to pass2pawan from comment #1)
> is the bug simply removing those files ?
Yep - and probably a reference to these files in a manifest.
Reporter | ||
Comment 3•8 years ago
|
||
(In reply to pass2pawan from comment #1)
> is the bug simply removing those files ?
Yes, it's removing these files, and the references in jar.mn package manifests, see http://searchfox.org/mozilla-central/search?q=syncProgress-
Note: the syncProgress-horizontalbar.png and syncProgress-horizontalbar@2x.png files are still used.
Keywords: good-first-bug
Assignee | ||
Comment 4•8 years ago
|
||
do i need to build firefox again after i remove these files ? And i want to know if there's a way to build individual folders like 'mach build browser '
Assignee | ||
Comment 5•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8818225 -
Flags: review?(florian)
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 8818225 [details] [diff] [review]
Bug-1319539.patch
Review of attachment 8818225 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me, thanks!
Attachment #8818225 -
Flags: review?(florian) → review+
Assignee | ||
Comment 7•8 years ago
|
||
will i be assigned the bug ?
Reporter | ||
Comment 8•8 years ago
|
||
Reporter | ||
Comment 9•8 years ago
|
||
(In reply to pass2pawan from comment #7)
> will i be assigned the bug ?
Yes, I'm assigning the bug to you. I pushed the patch to try to verify that things work OK on all platforms, as I assume you tested locally on only one of them. Assuming try is green, I'll push your patch to mozilla-inbound in the next day or two.
Assignee: nobody → pass2pawan
Reporter | ||
Comment 10•8 years ago
|
||
The try server results show bc test failures (browser_dragdropURL.js | Uncaught exception - at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:2063 - TypeError: aDataTransfer is undefined), they are unrelated and have been fixed by https://hg.mozilla.org/integration/mozilla-inbound/rev/b52932a0811b
Reporter | ||
Comment 11•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b075bfc532f327849e2bb9923cf9df2c9c82c99
Bug 1319539 - Remove leftover chrome://browser/skin/syncProgress-*.png files. r=florian
Comment 12•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Reporter | ||
Comment 13•8 years ago
|
||
Thanks for fixing this bug Pawan! If you would be interested in other similar bugs, you can have a look at the dependencies of bug 1316187 (https://bugzilla.mozilla.org/showdependencytree.cgi?id=1316187&hide_resolved=1)
Comment 14•8 years ago
|
||
when this bug landed our installer size reduced for windows- yay!
== Change summary for alert #4517 (as of December 14 2016 23:57 UTC) ==
Improvements:
0% installer size summary windows2012-64 pgo 57460995.5 -> 57263786.42
0% installer size summary windows2012-32 opt 53321609.33 -> 53138599.08
0% installer size summary windowsxp opt 53381928.25 -> 53200213.17
0% installer size summary windows2012-64 opt 57342213.67 -> 57155374.58
0% installer size summary windows2012-32 pgo 54479379.42 -> 54305596.92
0% installer size summary windows8-64 opt 57398811.58 -> 57213538.92
0% installer size summary windows8-64 pgo 57570554.25 -> 57413123.67
0% installer size summary windowsxp pgo 54598277.92 -> 54453335.75
0% installer size summary windows2012-32 debug 66862889.92 -> 66685301.83
0% installer size summary windowsxp debug 66942286.83 -> 66764153.92
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=4517
Assignee | ||
Comment 15•8 years ago
|
||
Hello i would like to patch the similar ones in this dependency tree bug 1316187 (https://bugzilla.mozilla.org/showdependencytree.cgi?id=1316187&hide_resolved=1), but when i try to remove and then build firefox i get an error saying the same files are missing , have the references really been commented out ?
Reporter | ||
Comment 16•8 years ago
|
||
(In reply to pass2pawan from comment #15)
> Hello i would like to patch the similar ones in this dependency tree bug
> 1316187
> (https://bugzilla.mozilla.org/showdependencytree.
> cgi?id=1316187&hide_resolved=1), but when i try to remove and then build
> firefox i get an error saying the same files are missing , have the
> references really been commented out ?
I replied in bug 1320126.
You need to log in
before you can comment on or make changes to this bug.
Description
•