Closed
Bug 1319634
Opened 8 years ago
Closed 7 years ago
FindProxyForURL().type should be able to return new value "pass"
Categories
(WebExtensions :: Request Handling, defect, P3)
WebExtensions
Request Handling
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1443259
People
(Reporter: mattw, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proxy] triaged)
Attachments
(1 file)
|
(deleted),
text/x-review-board-request
|
Details |
The "PASS" return type should pass on control to the next extension to determine the proxy configuration. We should fall back to "DIRECT" if there aren't any other extensions to pass control to.
For more information, see the proxy API design document: https://docs.google.com/document/d/1W45o5X2bFRPrTaQDFp9IzTJ8njCVfEgyENS7i2owaUI/edit?usp=sharing
|
||
Comment 1•8 years ago
|
||
How is this fixed/resolved? Is it already supported by the implementation in bug #1295807?
Flags: needinfo?(mwein)
|
Reporter | |
Comment 2•8 years ago
|
||
Flags: needinfo?(mwein)
|
|
Reporter | |
Updated•8 years ago
|
webextensions: --- → ?
|
|
Reporter | |
Updated•8 years ago
|
webextensions: ? → ---
|
|
||
Comment 3•7 years ago
|
||
This should become a new return type as part of bug 1381290.
Priority: -- → P3
|
|
||
Updated•7 years ago
|
Summary: Add support for the new "PASS" return type to FindProxyForURL → FindProxyForURL().type should be able to return new value "pass"
|
||
Comment 4•7 years ago
|
||
This already works if FindProxyForURL returns null.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
| Comment hidden (mozreview-request) |
|
|
||
Comment 6•7 years ago
|
||
(In reply to Shane Caraveo (:mixedpuppy) from comment #4)
> This already works if FindProxyForURL returns null.
On 57.0a1 (2017-09-03) (64-bit), retuning null from FindProxyForURL() results in the browser.proxy.onProxyError listener being called with the message "Return type must be a string"
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
According to my test result, it seems currently "DIRECT" does what "PASS" should do. See Bug 1398900 for details and steps to reproduce.
|
|
||
Comment 8•7 years ago
|
||
Given the new async api we will deprecate the non-complaint pac script initially done for webextensions.
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → DUPLICATE
|
||
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•