Closed
Bug 1319935
Opened 8 years ago
Closed 8 years ago
Remove String generics uses in devtools
Categories
(DevTools :: General, defect, P3)
DevTools
General
Tracking
(firefox53 fixed)
RESOLVED
FIXED
Firefox 53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
The various String generic methods are non-standard APIs and we plan to warn when they're used (bug 1319926) and eventually want to remove them completely (bug 1222552). As a first step we need to replace all String generic uses in Firefox with the counterpart from String.prototype.
In devtools/client/webconsole/test/browser_webconsole_bug_1006027_message_timestamps_incorrect.js, String.trim needs to be replaced with a call to String.prototype.trim.
In devtools/shared/gcli/commands/addon.js, String.localeCompare needs to be replaced with a call to String.prototype.localeCompare.
Priority: -- → P3
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8814228 -
Flags: review?(bgrinstead)
|
||
Updated•8 years ago
|
Attachment #8814228 -
Flags: review?(bgrinstead) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8361e025e4c7
Remove String generics uses in devtools. r=bgrins
Keywords: checkin-needed
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•