The various String generic methods are non-standard APIs and we plan to warn when they're used (bug 1319926) and eventually want to remove them completely (bug 1222552). As a first step we need to replace all String generic uses in Firefox with the counterpart from String.prototype. In toolkit/mozapps/extensions/content/blocklist.js and toolkit/mozapps/extensions/content/extensions.js, String.localeCompare needs to be replaced with a call to String.prototype.localeCompare.

Comment on attachment 8814233 [details] [diff] [review] bug1319939.patch Review of attachment 8814233 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! ::: toolkit/mozapps/extensions/content/blocklist.js @@ +27,5 @@ > bundle.GetStringFromName("restartLaterButton.accesskey")); > > var richlist = document.getElementById("addonList"); > var list = gArgs.list; > + list.sort(function(a, b) { return String(a.name).localeCompare(b.name); }); nit: this could be an arrow function w/ concise body if you want

Updated patch to replace the function expression with an arrow function per review comments. Carrying r+ from rhelmer.

(In reply to Robert Helmer [:rhelmer] from comment #2) > Thanks! Thanks for reviewing!

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5897fbfa16c9 Remove String generics uses in toolkit/mozapps/extensions/content. r=rhelmer