Closed
Bug 1320596
Opened 8 years ago
Closed 8 years ago
rustc not installing or upgrading
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: jya, Unassigned)
References
Details
Attachments
(1 file)
Had previously installed rust using : curl -sSf https://static.rust-lang.org/rustup.sh | sh
as described in https://www.rust-lang.org/en-US/downloads.html
However, I had version 1.12.1
Running ./mach bootstrap
"Looks like you have MacPorts installed. We will install all required packages via MacPorts.
Your version of Mercurial (3.9) is sufficiently modern.
Your version of Python (2.7.12) is new enough.
Will try to install Rust.
Downloading rustup-init... Ok
Running rustup-init...
warning: it looks like you have an existing installation of Rust
warning: rustup cannot be installed alongside Rust. Please uninstall first
warning: run `/usr/local/lib/rustlib/uninstall.sh` as root to uninstall Rust
error: cannot install while Rust is installed
Error running mach:
['bootstrap']
The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You should consider filing a bug for this issue."
So I ran /usr/local/lib/rustlib/uninstall.sh as root as written.
./mach bootstrap then gave:
"Looks like you have MacPorts installed. We will install all required packages via MacPorts.
Executing as root: sudo /opt/local/bin/port select --set python python27
Selecting 'python27' for 'python' succeeded. 'python27' is now active.
Your version of Mercurial (3.9) is sufficiently modern.
Your version of Python (2.7.12) is new enough.
Could not find a Rust compiler."
So you have to re-run manually curl -sSf https://static.rust-lang.org/rustup.sh after that.
Reporter | ||
Updated•8 years ago
|
Comment 1•8 years ago
|
||
I'm confused. After you ran `/usr/local/lib/rustlib/uninstall.sh`, `mach boostrap` printed "Could not find a Rust compiler," and stopped without downloading and running the installer for you? I don't see how that's possible.
Note that the bootstrap installer puts rust in $HOME/.cargo/bin so you need to add that to your path. Now that bug 1319860 has landed we should print a message about that.
Flags: needinfo?(jyavenard)
Reporter | ||
Comment 2•8 years ago
|
||
(In reply to Ralph Giles (:rillian) needinfo me from comment #1)
> I'm confused. After you ran `/usr/local/lib/rustlib/uninstall.sh`, `mach
> boostrap` printed "Could not find a Rust compiler," and stopped without
> downloading and running the installer for you? I don't see how that's
> possible.
yes exactly...
Maybe it's because I'm running mac port, and it doesn't provide a version greater than 1.11 and it looks like if mac port is in used there's no fallback to get a different version of rust.
>
> Note that the bootstrap installer puts rust in $HOME/.cargo/bin so you need
> to add that to your path. Now that bug 1319860 has landed we should print a
> message about that.
I had to manually install rust again as described in the first message.
Flags: needinfo?(jyavenard)
Comment 3•8 years ago
|
||
> error: cannot install while Rust is installed
I installed macports, and I can reproduce this part if I have an rust 1.13 in /usr/local/bin and 1.11 in /opt/local/bin. However, I can't reproduce the last part. After I run the uninstall script for the /usr/local version, bootstrap installs successfully in ~/.cargo/bin and subsequent invocations either repeat the install (if ~/.cargo/bin/rustc isn't found in the PATH) or say it's ok (if it is).
I can clean up the messages in this case a bit though.
Comment hidden (mozreview-request) |
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8815124 [details]
Bug 1320596 - mozboot: Handle old rustc but not rustup.
https://reviewboard.mozilla.org/r/96118/#review96264
Attachment #8815124 -
Flags: review?(gps) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/02c6731cc824
mozboot: Handle old rustc but not rustup. r=gps
Comment 7•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•